Skip to content

require logger name #1444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paulwe merged 2 commits into from
Mar 7, 2026
Merged

require logger name #1444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a56310
require logger name
paulwe Mar 6, 2026
c7cf672
Create long-seals-sleep.md
paulwe Mar 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/long-seals-sleep.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@livekit/protocol": patch
---

require logger name
4 changes: 2 additions & 2 deletions observability/reporter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ const Project = "livekit"
var discardLogger = logger.LogRLogger(logr.Discard())

type Reporter interface {
Logger(projectID string) (logger.Logger, error)
Logger(name, projectID string) (logger.Logger, error)
Room() roomobs.Reporter
Agent() agentsobs.Reporter
Gateway() gatewayobs.Reporter
Expand All @@ -39,7 +39,7 @@ func NewReporter() Reporter {

type reporter struct{}

func (reporter) Logger(projectID string) (logger.Logger, error) {
func (reporter) Logger(name, projectID string) (logger.Logger, error) {
return discardLogger, nil
}

Expand Down
Loading