Open
Conversation
This is needed to suggest parameters in method and parameter refinements
This is needed to use the annotation position to be able to suggested the variable we are refining in the autocomplete
rcosta358
force-pushed
the
context-history-improvements
branch
from
261fc57 to
dd62da8
Compare
This was referenced Mar 7, 2026
Closed
This is because we want to show the failed variable instance in the context debugger and otherwise it is never added to the context. Not sure if this change is correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes some changes to the context history to improve the autocomplete and the context debugger in the extension by:
filefield to ghosts to only suggest those in the fileRefinedVariable:isParameter- to know whether a refined variable is a parameter or not so we can bypass the condition that filters variables that are declared after the current positionannPosition- to use the annotation position to be able to suggest the variable we are refining in the autocompleteOther Changes
ErrorPositionclass which is unnecessary since we can use Spoon'sSourcePositionin diagnostics insteadAuxStateHandler, always add failing instances and substitutethiswith instance variable