chore(deps): upgrade Go from 1.24.0 to 1.26.1#12
Merged
flexiondotorg merged 6 commits intomainfrom Mar 12, 2026
Merged
Conversation
Contributor
flexiondotorg
commented
Mar 12, 2026
- Update go.mod to Go 1.26.1
- Update flake.nix to use go_1_26 package
- Update go.mod to Go 1.26.1 - Update flake.nix to use go_1_26 package Signed-off-by: Martin Wimpress <code@wimpress.io>
- dav1d: 1.5.2 → 1.5.3 - libdrm: 2.4.129 → 2.4.131 - libiconv: 1.18 → 1.19 - libsrt: 1.5.5-rc.0a → 1.5.5-rc.1 - libva: 2.22.0 → 2.23.0 - libvpl: 2.15.0 → 2.16.0 - libvpx: 1.15.2 → 1.16.0 - libxml2: 2.15.1 → 2.15.2 - nv-codec-headers: 12.2.72.0 → 13.0.19.0 - openssl: 3.6.0 → 3.6.1 - opus: 1.5.2 → 1.6.1 - Vulkan-Headers: 1.4.335 → 1.4.345 - vvenc: 1.13.1 → 1.14.0 - zlib: 1.3.1 → 1.3.2 Signed-off-by: Martin Wimpress <code@wimpress.io>
Signed-off-by: Martin Wimpress <code@wimpress.io>
There was a problem hiding this comment.
1 issue found across 2 files
Confidence score: 3/5
- There is a concrete compatibility risk in
go.mod: raising thegodirective can force consumers onto a newer Go toolchain, which is a breaking change for a library if not strictly required. - Given the issue’s medium severity (6/10) and high confidence (8/10), this is more than a housekeeping tweak and may impact downstream users’ build environments.
- Pay close attention to
go.mod- confirm the higher minimum Go version is truly needed by this PR before merging.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="go.mod">
<violation number="1" location="go.mod:3">
P2: This `go` directive unnecessarily raises the module's minimum supported toolchain. For a library module, that is a breaking compatibility change unless the code actually needs Go 1.26 features or fixes.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
…inning - Convert single quotes to double quotes for consistency - Replace hardcoded go-version with go-version-file for go.mod - Remove trailing whitespace - Standardise branch array formatting Signed-off-by: Martin Wimpress <code@wimpress.io>
There was a problem hiding this comment.
1 issue found across 7 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".github/workflows/ffmpeg-test.yml">
<violation number="1" location=".github/workflows/ffmpeg-test.yml:42">
P2: Because this job now reads the Go version from `go.mod`, `go.mod` changes need to trigger the workflow too. Otherwise Go upgrades can merge without ever running the FFmpeg build on the new toolchain.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Replace sort.Strings with slices.Sort (Go 1.21+) for generic type-safe sorting and filepath.Walk with filepath.WalkDir (Go 1.16+) for improved performance by avoiding extra stat calls. - lib/fetch.go: replace sort.Strings with slices.Sort - internal/builder/libraries.go: replace filepath.Walk with filepath.WalkDir Signed-off-by: Martin Wimpress <code@wimpress.io>
There was a problem hiding this comment.
1 issue found across 2 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="internal/builder/libraries.go">
<violation number="1" location="internal/builder/libraries.go:910">
P2: Propagate the `filepath.WalkDir` error instead of discarding it.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Previously the error from WalkDir was silently discarded, now it is properly propagated to the caller. Signed-off-by: Martin Wimpress <code@wimpress.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.