fix: update library dependency version format#165
Merged
18202781743 merged 1 commit intolinuxdeepin:masterfrom Oct 30, 2025
Merged
fix: update library dependency version format#16518202781743 merged 1 commit intolinuxdeepin:masterfrom
18202781743 merged 1 commit intolinuxdeepin:masterfrom
Conversation
Changed the library dependency version format from major.minor to major.minor.patch in dh_makeshlibs command. This ensures that the package dependency includes the full version number (including patch version) rather than just major and minor components. The modification updates the cut command from extracting fields 1,2 to fields 1,2,3 to include all three version components. This change is necessary to maintain proper dependency resolution and version compatibility, as the patch version can contain important bug fixes and security updates that should be considered when determining package dependencies. Influence: 1. Verify that package builds successfully with the new version format 2. Test package installation and dependency resolution 3. Check that library dependencies are correctly enforced during installation 4. Validate that the package manager properly handles the full version specification fix: 更新库依赖版本格式 将 dh_makeshlibs 命令中的库依赖版本格式从主版本.次版本更改为主版本.次版 本.修订版本。这确保包依赖包含完整的版本号(包括修订版本),而不仅仅是主 版本和次版本。修改将 cut 命令从提取字段 1,2 更新为字段 1,2,3 以包含所有 三个版本组件。 此变更是必要的,以维护正确的依赖解析和版本兼容性,因为修订版本可能包含重 要的错误修复和安全更新,在确定包依赖时应予以考虑。 Influence: 1. 验证包是否使用新版本格式成功构建 2. 测试包安装和依赖解析 3. 检查库依赖在安装过程中是否正确执行 4. 验证包管理器是否正确处理完整版本规范
Contributor
|
Warning
|
Contributor
deepin pr auto review我来对这个git diff进行审查:
改进建议:
PACKAGE_VERSION := $(shell echo $(VERSION) | cut -d '.' -f 1,2,3)
override_dh_makeshlibs:
dh_makeshlibs -V "libdtk6gui (>= $(PACKAGE_VERSION))"总体来说,这是一个合理的改进,提高了版本控制的精确度。建议合并这个修改。 |
BLumia
approved these changes
Oct 30, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, BLumia The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed the library dependency version format from major.minor to
major.minor.patch in dh_makeshlibs command. This ensures that the
package dependency includes the full version number (including patch
version) rather than just major and minor components. The modification
updates the cut command from extracting fields 1,2 to fields 1,2,3 to
include all three version components.
This change is necessary to maintain proper dependency resolution and
version compatibility, as the patch version can contain important bug
fixes and security updates that should be considered when determining
package dependencies.
Influence:
installation
specification
fix: 更新库依赖版本格式
将 dh_makeshlibs 命令中的库依赖版本格式从主版本.次版本更改为主版本.次版
本.修订版本。这确保包依赖包含完整的版本号(包括修订版本),而不仅仅是主
版本和次版本。修改将 cut 命令从提取字段 1,2 更新为字段 1,2,3 以包含所有
三个版本组件。
此变更是必要的,以维护正确的依赖解析和版本兼容性,因为修订版本可能包含重
要的错误修复和安全更新,在确定包依赖时应予以考虑。
Influence: