air: do not hard-code PW project link name#73
Closed
matttbe wants to merge 1 commit intolinux-netdev:mainfrom
Closed
air: do not hard-code PW project link name#73matttbe wants to merge 1 commit intolinux-netdev:mainfrom
matttbe wants to merge 1 commit intolinux-netdev:mainfrom
Conversation
Instances of pw_air_poller.py are not tracking 'Netdev + BPF' PW project like air-submit.py does. It is then required to save the project link name in the DB to be able to set links to the right PW project in the UI side. To be able to achieve that, the Patchwork class needs to remember the project link name that is present in the project info from PW, based on the project full name or ID given in the config. Then, this link name can be attached to the submission, and used in the UI if available. This should then fix the PW URLs on the reports linked to other PW instances like the MPTCP one. Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
matttbe
force-pushed
the
air-pw-project-name
branch
from
54f70a4 to
5b23960
Compare
Contributor
|
Just the links in the UI are broken right? The patchwork links and other things work? Let me fix this, the code base for |
Member
Author
From what I saw, yes.
Yes, for example this patch has the right link to the AI review page, but not the opposite. Same from: NIPA AIR main page.
Arf, but understandable :) |
Contributor
|
Took me a couple of attempts but it should be fixed now :) |
Member
Author
|
Thank you, I confirm it is fixed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instances using
pw_air_poller.pyare not tracking 'Netdev + BPF' PW project likeair-submit.pydoes (if I understood correctly). It is then required to save the project link name in the DB to be able to set links to the right PW project in the UI side.To be able to achieve that, the Patchwork class needs to remember the project link name that is present in the project info from PW, based on the project full name or ID given in the config. Then, this link name can be attached to the submission, and used in the UI if available.
This should then fix the PW URLs on the reports linked to other PW instances like the MPTCP one, e.g. here.
Warning
I was not able to test this, and I don't have access to the config files, so I hope the modifications are correct :)