[RFC] pw_poller: poll events, not series#47
Merged
kuba-moo merged 1 commit intolinux-netdev:mainfrom Apr 24, 2025
Merged
Conversation
Contributor
|
Manual reinit is fine, I reckon. We could try to maintain the seen series for a bit to discard the 2h overlap after first restart, but seems like an overkill. I'll redeploy our instances on the weekend when traffic is low. |
It's much easier since events get a timestamp from the server, not from the email. It should also be cheaper for the server since we can limit to the last event we saw before. Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Member
Author
|
Sure, done. FWIW I've been running it for wireless since I pushed it, and happy with it - reacts much faster. |
Contributor
|
Thanks! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's much easier since events get a timestamp from the server, not from the email. It should also be cheaper for the server since we can limit to the last event we saw before.
RFC because I'm not sure how you'd want to to handle the switch-over ... the state is re-initialized. For myself I just decided to do it manually and not worry about seen series etc.