Add qdl-ramdump usage documentation and fix segment filter matching#202
Open
igoropaniuk wants to merge 3 commits intolinux-msm:masterfrom
Open
Add qdl-ramdump usage documentation and fix segment filter matching#202igoropaniuk wants to merge 3 commits intolinux-msm:masterfrom
igoropaniuk wants to merge 3 commits intolinux-msm:masterfrom
Conversation
Contributor
igoropaniuk
commented
Mar 25, 2026
igoropaniuk
commented
- README: new "Collect crash dump" section documenting the 0x900e USB PID, how to trigger a kernel crash, qdl-ramdump invocation, and the segment filter syntax
- qdl-ramdump: replace the single-line synopsis with a full per-option help text
- sahara: fix segment filter silently skipping everything - bare names like OCIMEM never matched device-advertised filenames like OCIMEM.BIN because pattern_match() requires an exact match; the filter now also tests against the filename stem
Contributor
Author
andersson
requested changes
Mar 25, 2026
README.md
Outdated
| echo c > /proc/sysrq-trigger | ||
| ``` | ||
|
|
||
| Use `qdl-ramdump` on the host to collect the dump: |
Collaborator
There was a problem hiding this comment.
Please see ff1a3bb ("ramdump: Make ramdump a qdl subcommand")
I'd prefer that we phase out qdl-ramdump.
Contributor
Author
There was a problem hiding this comment.
Fixed, thanks!
Let me know if you still wanna keep this commit qdl-ramdump: expand usage help to document all options or better to drop it.
igoropaniuk
force-pushed
the
refactor/ramdump_improvements
branch
from
4aa72d5 to
22a7df2
Compare
The device advertises segment filenames with extensions (e.g. OCIMEM.BIN), but users naturally pass bare names like OCIMEM as filter tokens. pattern_match() performs an exact match, so OCIMEM never matched OCIMEM.BIN and all segments were skipped regardless of the filter. Match each token against both the full filename and the stem (the part before the last dot) so that bare names, full names, and wildcard patterns all work as expected. The stem buffer is zero-initialized and stem[0] is used to determine whether a valid stem was extracted. Signed-off-by: Igor Opaniuk <igor.opaniuk@oss.qualcomm.com>
The original help string was a single synopsis line with no explanation of individual options, making it hard for new users to discover the --output, --serial, and segment filter arguments without reading the source code. Signed-off-by: Igor Opaniuk <igor.opaniuk@oss.qualcomm.com>
The README had no mention of crash dump collection, leaving users without guidance on which USB PID the device uses after a crash (0x900e), how to trigger a kernel crash, or how to use the segment filter. Signed-off-by: Igor Opaniuk <igor.opaniuk@oss.qualcomm.com>
igoropaniuk
force-pushed
the
refactor/ramdump_improvements
branch
from
22a7df2 to
0af8417
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.