qdl: add --zlp-timeout option to override USB write timeout#200
Closed
igoropaniuk wants to merge 1 commit intolinux-msm:masterfrom
Closed
qdl: add --zlp-timeout option to override USB write timeout#200igoropaniuk wants to merge 1 commit intolinux-msm:masterfrom
igoropaniuk wants to merge 1 commit intolinux-msm:masterfrom
Conversation
Some storage backends (notably SPINOR) need significantly more time to complete write operations than the built-in defaults allow. The hard-coded 10s/60s timeouts cannot account for all device and flash combinations, causing spurious "bulk write failed: Operation timed out" failures during programming. Expose the ZLP write timeout as a CLI parameter so users can tune it for their hardware without requiring a code change. Signed-off-by: Igor Opaniuk <igor.opaniuk@oss.qualcomm.com>
Collaborator
|
No thanks. Such command line argument merely serves the purpose of encoding the timeout in tribal knowledge, instead of making sure that the tool actually works for people. Let's figure out what the expected behavior is and put that knowledge in the source code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some storage backends (notably SPINOR) need significantly more time to complete write operations than the built-in defaults allow. The hard-coded 10s/60s timeouts cannot account for all device and flash combinations, causing spurious "bulk write failed: Operation timed out" failures during programming.
Expose the ZLP write timeout as a CLI parameter so users can tune it for their hardware without requiring a code change.