shellcheck: Fix shellcheck v0.11.0 issues detected in fsverity.test#32
Open
stefanberger wants to merge 1 commit intolinux-integrity:next-testingfrom
Open
shellcheck: Fix shellcheck v0.11.0 issues detected in fsverity.test#32stefanberger wants to merge 1 commit intolinux-integrity:next-testingfrom
stefanberger wants to merge 1 commit intolinux-integrity:next-testingfrom
Conversation
Fix the following issue detected by shellcheck:
if [ "x$(id -u)" != "x0" ]; then
^---------^ SC2268 (style): Avoid x-prefix in comparisons as it no \
longer serves a purpose.
Also fix several of the following types of issues by disabling the
shellcheck error. Shellcheck does not recognize the invocation of functions
when they are indirectly invoked when they are passed as parameter to
another function.
__skip() { return "$SKIP"; }
^-- SC2329 (info): This function is never invoked. Check usage (or \
ignored if invoked indirectly).
Also see: https://www.shellcheck.net/wiki/SC2329
Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
stefanberger
force-pushed
the
fix-shellcheck
branch
from
2414255 to
f24a082
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the following issue detected by shellcheck:
if [ "x$(id -u)" != "x0" ]; then
^---------^ SC2268 (style): Avoid x-prefix in comparisons as it no
longer serves a purpose.
Also fix several of the following types of issues where shellcheck does not recognize the invocation of functions when they are indirectly invoked when they are passed as parameter to another function.
__skip() { return "$SKIP"; }
^-- SC2329 (info): This function is never invoked. Check usage (or
ignored if invoked indirectly).
Also see: https://www.shellcheck.net/wiki/SC2329