[DataLoader] Add ArrivalOrder API and batch_size support#537
Merged
robreeves merged 1 commit intolinkedin:mainfrom Apr 10, 2026
Merged
[DataLoader] Add ArrivalOrder API and batch_size support#537robreeves merged 1 commit intolinkedin:mainfrom
robreeves merged 1 commit intolinkedin:mainfrom
Conversation
…iceberg Re-introduce the ArrivalOrder scan order and batch_size parameter that were removed in linkedin#504. The original removal was necessary because the fork dependency (sumedhsakdeo/iceberg-python) could not pass ELR. Now that li-pyiceberg 0.11.3 includes the ArrivalOrder API from upstream (apache/iceberg-python#3046), we can restore the functionality using an approved registry dependency.
ShreyeshArangath
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-introduce the
ArrivalOrderscan order andbatch_sizeparameter that were removed in #504. The original removal was necessary because the fork dependency (sumedhsakdeo/iceberg-python) made it ineligible for use internally at LI. Now thatli-pyiceberg==0.11.3includes theArrivalOrderAPI from upstream (apache/iceberg-python#3046), we can restore the functionality using an approved registry dependency.In a future PR, we will add support for streaming multiple splits concurrently using
ArrivalOrderwithconcurrent_streams > 1.Changes
pyproject.toml— Bumpli-pyicebergfrom0.11.2to0.11.3which includes theArrivalOrderAPI.data_loader.py— Re-addbatch_sizeparameter toOpenHouseDataLoader.__init__, forwarded to eachDataLoaderSplit.data_loader_split.py— Re-addArrivalOrderimport andbatch_sizeparameter.to_record_batches()now usesorder=ArrivalOrder(concurrent_streams=1, batch_size=self._batch_size).uv.lock— Regenerated to resolveli-pyiceberg==0.11.3from the internal registry.Tests — Re-add
test_arrival_order.py(verifiesScanOrderclass hierarchy andArrowScan.to_record_batcheswithorderparameter). Re-addbatch_sizetests intest_data_loader.py,test_data_loader_split.py, andintegration_tests.py.Testing Done
make verifypasses — 202 tests pass, lint, format, and mypy all green.Additional Information
batch_sizeis re-added toOpenHouseDataLoaderandDataLoaderSplit. This is additive (new optional parameter with defaultNone), so existing callers are unaffected.