feat: adding TagDiscovery panel feature (#494)#500
feat: adding TagDiscovery panel feature (#494)#500EmanuelGF wants to merge 1 commit intolinkdotnet:masterfrom
Conversation
|
Hey @EmanuelGF, thanks for filing the PR. We are off to a good start, there are some rough edges to iron out: It seems the padding vertically seems a bit off. Horizontally is also off, if you switch to responsive/mobile: |
| "UseMultiAuthorMode": false | ||
| "UseMultiAuthorMode": false, | ||
| "EnableTagDiscoveryPanel": true, | ||
| "ShowTagsWithCountInTagDiscovery": true |
There was a problem hiding this comment.
I would remove that - we can always show them
| "ShowBuildInformation": true, | ||
| "UseMultiAuthorMode": false | ||
| "UseMultiAuthorMode": false, | ||
| "EnableTagDiscoveryPanel": true, |
There was a problem hiding this comment.
This also needs some documentation in the docs/ directory: There is a part where we describes all the settings
| { | ||
| var unique = Guid.NewGuid().ToString("N"); | ||
|
|
||
| return BlogPost.Create( |
There was a problem hiding this comment.
nitpick: There should be a BlogPostBuilder where you would only need the WithTags function
| var posts = await blogPostRepository.GetAllAsync(); | ||
|
|
||
| var tagCounts = posts | ||
| // Flatten the collection of tag lists into a single sequence. |
There was a problem hiding this comment.
Those comments are so obvious they can be removed. I assume copilot/... did create them
|
|
||
| protected override async Task OnParametersSetAsync() | ||
| { | ||
| if (IsOpen && _tags.Count == 0) |
There was a problem hiding this comment.
Edge case: But that leads to stale updates as a creator. If I create an entry and open the dialog, it will show only the initially set version.
There was a problem hiding this comment.
Probably we are better off with a cached version with timing or other means (like we do with the frontpage)
| @@ -0,0 +1,70 @@ | |||
| .tag-overlay { | |||
There was a problem hiding this comment.
The idea is to have as little as possible custom css. Either by using bottstrap 5 itself (which to a big extend should be possible here) or at least move it into the central basic.css
|
Greetings! Have a great week!! |
2 participants
This PR introduces a new TagDiscovery feature discussed in issue #494 allowing users to discover blog topics via a tag discovery panel accessible from the navigation bar.