Skip to content

LCORE-1117: updated Pyright exclusion#1426

Merged
tisnik merged 1 commit intolightspeed-core:mainfrom
tisnik:lcore-1117-pyright-exclusion
Mar 29, 2026
Merged

LCORE-1117: updated Pyright exclusion#1426
tisnik merged 1 commit intolightspeed-core:mainfrom
tisnik:lcore-1117-pyright-exclusion

Conversation

@tisnik
Copy link
Copy Markdown
Contributor

@tisnik tisnik commented Mar 29, 2026

Description

LCORE-1117: updated Pyright exclusion

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement
  • Benchmarks improvement

Tools used to create PR

  • Assisted-by: N/A
  • Generated by: N/A

Related Tickets & Documents

  • Related Issue #LCORE-1117

Summary by CodeRabbit

  • Chores
    • Improved code quality by enabling type-checking for internal modules.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 29, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 444ce62b-7d63-462f-8aa4-7983d68772ab

📥 Commits

Reviewing files that changed from the base of the PR and between 03d16c7 and 876be6c.

📒 Files selected for processing (1)
  • pyproject.toml
💤 Files with no reviewable changes (1)
  • pyproject.toml
📜 Recent review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: build-pr
  • GitHub Check: Konflux kflux-prd-rh02 / lightspeed-stack-on-pull-request
  • GitHub Check: E2E: server mode / ci
  • GitHub Check: E2E: library mode / ci
  • GitHub Check: E2E Tests for Lightspeed Evaluation job

Walkthrough

Removed src/app/endpoints/conversations.py from Pyright's exclusion list in pyproject.toml, enabling type-checking for that file instead of skipping it.

Changes

Cohort / File(s) Summary
Pyright Configuration
pyproject.toml
Removed src/app/endpoints/conversations.py from tool.pyright.exclude list to enable type-checking on that file.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: removing a file from Pyright's exclusion list in the configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
✨ Simplify code
  • Create PR with simplified code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tisnik tisnik merged commit 43e2c6a into lightspeed-core:main Mar 29, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant