Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✱ Stainless preview buildsThis PR will update the kotlin openapi python typescript
|
Greptile SummaryThis PR adds Ethereum L1 mainnet as a new payment rail, introducing Key changes:
Confidence Score: 5/5
|
| Filename | Overview |
|---|---|
| openapi/components/schemas/common/EthereumWalletInfo.yaml | New base schema for Ethereum L1 wallet address, following the same structure as BaseWalletInfo.yaml. Required fields (address, accountType) are correctly declared. Trailing newline is present. |
| openapi/components/schemas/common/PaymentEthereumWalletInfo.yaml | New payment instruction schema composing BasePaymentAccountInfo and EthereumWalletInfo, with an optional assetType field limited to USDC. Title is correctly set to Ethereum Wallet, consistent with other Payment*WalletInfo schemas. |
| openapi/components/schemas/external_accounts/EthereumWalletExternalAccountInfo.yaml | New external account schema composing BaseExternalAccountInfo and EthereumWalletInfo. Follows the same pattern as BaseWalletExternalAccountInfo.yaml. Trailing newline is present. |
| openapi/components/schemas/external_accounts/ExternalAccountInfoOneOf.yaml | Adds EthereumWalletExternalAccountInfo to the oneOf list and discriminator mapping. Also removes the erroneous LIGHTNING_ACCOUNT discriminator key (the correct enum value is LIGHTNING, which remains intact at line 64). |
| openapi/components/schemas/common/PaymentInstructions.yaml | Correctly adds PaymentEthereumWalletInfo to both the oneOf list and discriminator mapping. No ordering or structural issues. |
| openapi.yaml | Bundled file correctly reflects all source changes: new EthereumWalletInfo and PaymentEthereumWalletInfo schemas with correct titles, updated PaymentInstructions and ExternalAccountInfoOneOf discriminator mappings, and removal of the erroneous LIGHTNING_ACCOUNT mapping key. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[API Client] -->|accountType: ETHEREUM_WALLET| B{Discriminator}
B -->|PaymentInstructions| C[PaymentEthereumWalletInfo]
B -->|ExternalAccount| D[EthereumWalletExternalAccountInfo]
C --> E[BasePaymentAccountInfo\ncurrency, amount, etc.]
C --> F[EthereumWalletInfo\naddress, accountType]
C --> G[assetType: USDC]
D --> H[BaseExternalAccountInfo\nid, accountType, etc.]
D --> F
style F fill:#f0f4ff,stroke:#4a6fa5
style C fill:#e8f5e9,stroke:#2e7d32
style D fill:#fff3e0,stroke:#e65100
Last reviewed commit: "Re-build"
openapi/components/schemas/common/PaymentEthereumWalletInfo.yaml
Outdated
Show resolved
Hide resolved
openapi/components/schemas/external_accounts/EthereumWalletExternalAccountInfo.yaml
Outdated
Show resolved
Hide resolved
jklein24
left a comment
There was a problem hiding this comment.
@greptile please re-review and re-score

No description provided.