Skip to content

feat: migrate sl to lifo-pkg-sl package#10

Open
FrederickStempfle wants to merge 1 commit intolifo-sh:mainfrom
FrederickStempfle:feat/lifo-pkg-sl
Open

feat: migrate sl to lifo-pkg-sl package#10
FrederickStempfle wants to merge 1 commit intolifo-sh:mainfrom
FrederickStempfle:feat/lifo-pkg-sl

Conversation

@FrederickStempfle
Copy link
Copy Markdown
Contributor

Summary

Moves the `sl` (steam locomotive) command out of core and into its own
`lifo-pkg-sl` package, following the same pattern as `lifo-pkg-git` and
`lifo-pkg-ffmpeg`.

  • Removes `sl` from `@lifo-sh/core`'s command registry
  • Creates `packages/lifo-pkg-sl` with its own build config and README
  • Registers it in the playground alongside the other pkg commands
  • Published to npm as `lifo-pkg-sl@0.5.1`

Users can now install it with `lifo install sl`.

@DaminiPandey
Copy link
Copy Markdown
Contributor

@FrederickStempfle Thanks for the update. This looks great and follows the same pattern as lifo-pkg-git and lifo-pkg-ffmpeg, which is nice to see.

We noticed you’ve published it as lifo-pkg-sl@0.5.1. If you’d like us to keep it under the official Lifo packages, could you add us as an owner on npm? Without owner access, we won’t be able to properly manage or maintain it on our side.

Once that’s sorted, we’re happy to take it forward.

@FrederickStempfle
Copy link
Copy Markdown
Contributor Author

@FrederickStempfle Thanks for the update. This looks great and follows the same pattern as lifo-pkg-git and lifo-pkg-ffmpeg, which is nice to see.

We noticed you’ve published it as lifo-pkg-sl@0.5.1. If you’d like us to keep it under the official Lifo packages, could you add us as an owner on npm? Without owner access, we won’t be able to properly manage or maintain it on our side.

Once that’s sorted, we’re happy to take it forward.

sure, send me all the npm usernames you want me to add to it.

@DaminiPandey
Copy link
Copy Markdown
Contributor

You can add sanketsahu.

@FrederickStempfle
Copy link
Copy Markdown
Contributor Author

You can add sanketsahu.

@DaminiPandey @sanketsahu i added him :)

@sanketsahu
Copy link
Copy Markdown
Contributor

thanks! we will review and merge.

@FrederickStempfle
Copy link
Copy Markdown
Contributor Author

sounds good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants