Fix compiling to webOS / add to CI#259
Conversation
|
Helix sources aren't provided for licensing issues in the picodrive repo. |
|
Does it need them to compile? I can always look at another fix (it compiles fine atm) |
|
No, it compiles in a shard library loader for helix. However, there wouldn't be mp3 sound output without that shard library in place. |
|
OK i'll see about another fix then 👍 |
|
I remember having something similar for another lr platform ages ago. Let me try to find it. |
|
Look at platform/common/mp3_drmp3.c. In line 13, it checks for libretro VFS usage and cuts out some functions. That would be a good place to add something for this special case. Defining a wrapper function for fopen64 to use fopen in case it is compiled on webos is probably the simplest method. |
|
Thanks, updated PR 👍 |
|
I've adjusted the way CYCLONE_CC/CXX is passed as otherwise it was still picking up the arm compiler instead of the native one. |
c3e3893 to
9e93711
Compare
50adc8d to
dc52ce3
Compare
|
Gitlab CI updated now as we are using libretro buildbot for the core |
|
Sorry for having been unresponsive for such a long time. I just needed some time off for regenerating. |
d64cc84 to
6177164
Compare
…rom incompatible pointer type ‘FILE *’
|
NP and PR updated 👍 |
|
Thank you! |
Currently fails to build due an issue with dr_mp3
So switched to MP3 helix (as it is ARM).. 👍