Skip to content

Fix compiling to webOS / add to CI#259

Merged
irixxxx merged 3 commits intolibretro:masterfrom
cscd98:webos
Apr 2, 2026
Merged

Fix compiling to webOS / add to CI#259
irixxxx merged 3 commits intolibretro:masterfrom
cscd98:webos

Conversation

@cscd98
Copy link
Copy Markdown

@cscd98 cscd98 commented Dec 6, 2025

Currently fails to build due an issue with dr_mp3

platform/common/dr_libs/dr_mp3.h: In function ‘drmp3_fopen’:
platform/common/dr_libs/dr_mp3.h:3362:17: error: assignment to ‘RFILE *’ from incompatible pointer type ‘FILE *’ [-Wincompatible-pointer-types]
 3362 |         *ppFile = fopen64(pFilePath, pOpenMode);

So switched to MP3 helix (as it is ARM).. 👍

@irixxxx
Copy link
Copy Markdown
Collaborator

irixxxx commented Dec 8, 2025

Helix sources aren't provided for licensing issues in the picodrive repo.

@cscd98
Copy link
Copy Markdown
Author

cscd98 commented Dec 8, 2025

Does it need them to compile? I can always look at another fix (it compiles fine atm)

@irixxxx
Copy link
Copy Markdown
Collaborator

irixxxx commented Dec 8, 2025

No, it compiles in a shard library loader for helix. However, there wouldn't be mp3 sound output without that shard library in place.

@cscd98
Copy link
Copy Markdown
Author

cscd98 commented Dec 8, 2025

OK i'll see about another fix then 👍

@irixxxx
Copy link
Copy Markdown
Collaborator

irixxxx commented Dec 8, 2025

I remember having something similar for another lr platform ages ago. Let me try to find it.

@irixxxx
Copy link
Copy Markdown
Collaborator

irixxxx commented Dec 8, 2025

Look at platform/common/mp3_drmp3.c. In line 13, it checks for libretro VFS usage and cuts out some functions. That would be a good place to add something for this special case.

Defining a wrapper function for fopen64 to use fopen in case it is compiled on webos is probably the simplest method.

@cscd98
Copy link
Copy Markdown
Author

cscd98 commented Dec 11, 2025

Thanks, updated PR 👍

@cscd98
Copy link
Copy Markdown
Author

cscd98 commented Dec 12, 2025

I've adjusted the way CYCLONE_CC/CXX is passed as otherwise it was still picking up the arm compiler instead of the native one.

@cscd98 cscd98 force-pushed the webos branch 5 times, most recently from c3e3893 to 9e93711 Compare December 12, 2025 11:29
@cscd98 cscd98 force-pushed the webos branch 2 times, most recently from 50adc8d to dc52ce3 Compare December 20, 2025 11:32
@cscd98 cscd98 changed the title Fix compiling to webOS Fix compiling to webOS / add to CI Mar 31, 2026
@cscd98
Copy link
Copy Markdown
Author

cscd98 commented Mar 31, 2026

Gitlab CI updated now as we are using libretro buildbot for the core

@irixxxx
Copy link
Copy Markdown
Collaborator

irixxxx commented Mar 31, 2026

Sorry for having been unresponsive for such a long time. I just needed some time off for regenerating.
I have added some comments to certain patches. It's more about style than really functional. Have a look at them please, and feel free to throw back at me.

@cscd98 cscd98 force-pushed the webos branch 3 times, most recently from d64cc84 to 6177164 Compare April 1, 2026 19:14
@cscd98
Copy link
Copy Markdown
Author

cscd98 commented Apr 1, 2026

NP and PR updated 👍

@irixxxx irixxxx merged commit f0d4a01 into libretro:master Apr 2, 2026
@irixxxx
Copy link
Copy Markdown
Collaborator

irixxxx commented Apr 2, 2026

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants