Fix: correct usage of Set prototype APIs#3548
Open
dragonJadeRan wants to merge 3 commits intolibnoname:mainfrom
Open
Fix: correct usage of Set prototype APIs#3548dragonJadeRan wants to merge 3 commits intolibnoname:mainfrom
dragonJadeRan wants to merge 3 commits intolibnoname:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ECMAScript2025在Set的原型上新增了一些方法，这些方法的参数不一定非得是 Set 对象。它可以是任何 Set-like 对象（即具有 .size 属性和 .has() 方法的对象，或者是任何可迭代对象，如 Array 或 Map）。
我在打包无名杀时为了性能会删除core-js-bundle，但是在webview148上运行时发现报错：.size is NaN。
将元素显式地转化为Set即可消除，在core-js-bundle存在时也不会造成影响