Merged
Conversation
Collaborator
Author
|
牢骚哥梯子炸了故带其口诏自合(悲喜交加) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR受影响的平台
无
诱因和背景
修复game.addCharacterPack被修改后,pack.character的character被get.convertedCharacter后阵亡配音和武将图片地址引用还是牢array方法导致的武将图片显示问题和阵亡配音引用问题
PR描述
修改了game.addCharacterPack的阵亡配音和武将图片地址引用为get.convertedCharacter后所需格式,同时修改pack.character也将最终值改为了get.convertedCharacter格式以修复武将包界面的武将阵亡配音和图片显示问题
但目前仍存在一个问题,game.addCharacterPack因为会提前引用好阵亡配音和武将图片,如果pack.character里面的武将定义用的是原来的array格式,那直接使用ext:db:mode:character:引用武将图片时,会直接被img覆盖导致此段内容失效,但是要在array转get.convertedCharacter情况下兼容ext:db:mode:character:适配图片,直接引用setBackground逻辑也会在史山上面更进一步,所以暂时没办法修改,等牢骚哥@xizifu 出来拯救
PR测试
用写过game.addCharacterPack的牢扩展包测了,能跑
扩展适配
无
检查清单
WIP直到本PR内容全部提交character/rank.js中添加对应的武将强度评级,并对双人武将/复姓武将添加name:xxx的参数lib.translate中加入语音文件的文字台词PR描述中写入详细文档扩展适配中写入详细文档诱因和背景中明确链接到该issue.editorconfig、eslint.config.mjs和prettier.config.mjs所规定的代码样式,并且已经通过prettier格式化过代码