Handle updating records with multiple values#29
Open
andsens wants to merge 1 commit intolibdns:mainfrom
Open
Conversation
andsens
force-pushed
the
ft-multivalue-records
branch
from
c3ef771 to
5e93666
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously when creating e.g. A records with multiple IPs one would receive the error message "unexpectedly found more than 1 record for ...".
This change implements code for handling that scenario by grouping records by type and name, and then making the total set of records match the given ones (i.e. update until existing or new list exhausted, then append the remaining new records or delete the remaining existing ones).
EDIT: Highly recommend looking at the diff in split-view. It's a mess to read otherwise.