installer: create EFI NVRAM boot entry for EVE-OS after installation#5712
Open
rucoder wants to merge 2 commits intolf-edge:masterfrom
Open
installer: create EFI NVRAM boot entry for EVE-OS after installation#5712rucoder wants to merge 2 commits intolf-edge:masterfrom
rucoder wants to merge 2 commits intolf-edge:masterfrom
Conversation
rucoder
requested review from
milan-zededa,
rouming,
shjala and
zedi-pramodh
as code owners
github-actions
bot
requested review from
OhmSpectator,
andrewd-zededa,
europaul,
jsfakian and
naiming-zededa
rucoder
force-pushed
the
rucoder/boot-entry-v2
branch
5 times, most recently
from
0fae539 to
f0485c6
Compare
After writing the EFI partition to disk, the installer did not create an EFI NVRAM boot entry. On some hardware and firmware configurations this means EVE-OS would not appear in the boot menu and the system might not boot into EVE without manual BIOS intervention. Add create_efi_boot_entry() to the installer script. It detects the EFI bootloader path by architecture (x86_64, ARM64, RISCV64) from the installer's own EFI files, removes any pre-existing "EVE-OS" NVRAM entries to avoid duplicates on reinstall, then creates a new entry pointing to the correct EFI bootloader on the installed disk. Add efibootmgr as a runtime dependency of the installer container and register it in the Alpine 3.16 package mirror. Signed-off-by: Mikhail Malyshev <mike.malyshev@gmail.com>
Update all Dockerfiles to use the current eve-alpine base image hash as required by the repo consistency check. Signed-off-by: Mikhail Malyshev <mike.malyshev@gmail.com>
rucoder
force-pushed
the
rucoder/boot-entry-v2
branch
from
f0485c6 to
dafd328
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
this is a reincarnation of very old branch i found on my disk.
After writing the EFI partition to disk, the installer did not create an EFI NVRAM boot entry. On some hardware and firmware configurations this means EVE-OS would not appear in the boot menu after installation and the system
might not boot into EVE without manual BIOS intervention.
This change adds
create_efi_boot_entry()to the installer script. It:/root/EFI/BOOT/via the linuxkit init layer)efibootmgrefibootmgris added as a runtime dependency of the installer container and registered in the Alpine 3.16 package mirror.How to test and validate this PR
make installerone "EVE-OS" entry (no duplicates)
Alternatively, test in QEMU with OVMF:
Changelog notes
EVE-OS installer now creates an EFI NVRAM boot entry during installation, ensuring the device boots into EVE-OS automatically after installation on EFI-capable hardware.
PR Backports
Checklist
I've provided a proper description
I've added the proper documentation
I've tested my PR on amd64 device
I've tested my PR on arm64 device
I've written the test verification instructions
I've set the proper labels to this PR
I've checked the boxes above, or I've provided a good reason why I didn't
check them.