Conversation
simlmx
force-pushed
the
deal-with-meta-earlier
branch
2 times, most recently
from
86a2c42 to
e6227f0
Compare
We let `executePlayerMove` and `executeBoardMove` deal with it directly, instead of it being a follow up step.
`valtio` created re-renders problems. `zustand` is closer to our `redux` mindset and works well with our `immer` pathes.
This enables optimistic UI for things that require the current timestamp. An estimated "server timestamp" will be used. Remember: when the move runs on the backend, it will get the "real" timestamp, and the move executed on the client will be reversed and the patches from the backend will be used.
This makes problems with optimistic UI easier to figure out.
simlmx
force-pushed
the
deal-with-meta-earlier
branch
from
9c64967 to
c85b9a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.