Fix database prefixes and a lot of other small things#22
Open
TamaroWalter wants to merge 14 commits intomainfrom
Open
Fix database prefixes and a lot of other small things#22TamaroWalter wants to merge 14 commits intomainfrom
TamaroWalter wants to merge 14 commits intomainfrom
Conversation
TamaroWalter
force-pushed
the
fix/db_settings_overall
branch
from
21b495d to
2512b0c
Compare
The table was build manually using echo statements. The UI therefore looked out of place. Now, it uses \core_table\flexible_table which does the HTML rendering for us.
The pg lite class checks if the pg_connection_status() is false. Problem is: a good connection status (PGSQL_CONNECTION_OK) equals the integer 0. php values a 0 equal to "false" and because of that, a failed connection is stated although the connection is okay.
if the types are stated moodle_form complains: Declaration must be compatible with moodleform->validation(data: array, files: array)
For some reason, using the logical & caused that on install the lsf_unification datatables were not created
dlmsr
force-pushed
the
fix/db_settings_overall
branch
from
5151c9b to
e91db63
Compare
As many lsf-categories can map to the same Moodle category, the 'mdlid' is not an unique array key. In one testcase Moodle complained about it.
dlmsr
force-pushed
the
fix/db_settings_overall
branch
from
e91db63 to
2983220
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔀 Purpose of this PR:
📝 Description:
This PR has different little fixes from bugs that occurred from previous commits as well as older bugs that were found during testing through the plugin.
At this state, i can successfully create courses based on the lsf_view tables that i get through the 'update_helptable' cronjob.
Note: This branch was created from another feature-branch that was not merged to main, but is now.