fix: add checkInterrupted to Core.withIncRecDepth#13290
Merged
Conversation
…sponsiveness This PR adds a `checkInterrupted` call to `Core.withIncRecDepth`, so that all recursive CoreM-based operations (inferType, whnf, isDefEq, simp, …) check for cancellation on each recursion step. Previously, these operations could run for seconds without responding to IDE cancellation requests. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
Author
|
!radar |
|
Benchmark results for 4d782a6 against c4a664e are in. There are no significant changes. @nomeata
Small changes (8🟥)
|
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
checkInterruptedcall toCore.withIncRecDepth, so that all recursive CoreM-based operations (inferType, whnf, isDefEq, simp, …) check for cancellation on each recursion step. Previously, these operations could run for seconds without responding to IDE cancellation requests.This is the single highest-impact change for IDE cancellation responsiveness. It covers all recursive MetaM/TacticM operations at once, eliminating the vast majority of multi-second gaps identified by the
LEAN_CHECK_SYSTEM_INTERVAL_MSmonitoring in #13212.Gap measurements pending — will be added after CI benchmarks and instrumented measurement.
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com