chore: preparatory changes for removing defeq transparency bump#13279
Open
leodemoura wants to merge 2 commits intomasterfrom
Open
chore: preparatory changes for removing defeq transparency bump#13279leodemoura wants to merge 2 commits intomasterfrom
leodemoura wants to merge 2 commits intomasterfrom
Conversation
…tions This PR adds `implicit_reducible` and/or `expose` attributes to definitions that need to be unfolded during defeq checking without full transparency. Preparatory commit for removing the TODO workaround in ExprDefEq.lean. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-actions
bot
added
the
toolchain-available
mathlib-nightly-testing bot
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Apr 4, 2026
github-actions
bot
added
the
mathlib4-nightly-available
mathlib-nightly-testing bot
pushed a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Apr 4, 2026
leanprover-bot
added a commit
to leanprover/reference-manual
that referenced
this pull request
Apr 4, 2026
leanprover-bot
added
the
builds-manual
Collaborator
|
Reference manual CI status:
|
mathlib-lean-pr-testing
bot
added
the
breaks-mathlib
|
Mathlib CI status (docs):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
implicit_reducible/exposeattributes to definitions that need them before thewithInferTypeConfigtransparency bump incheckTypesAndAssigncan be removed (seeExprDefEq.lean:465).The transparency bump currently compensates for certain definitions not being
reducible during type inference in the definitional equality checker. By marking
these definitions appropriately, we prepare for removing the bump without
breaking existing proofs.
Changes:
implicit_reducibleand/orexposetoFunction.comp,cond,Nat.lt,Option.getD,Option.getM,Option.isSome,Option.isNone,SyntaxNodeKinds,wfParam,Id,StateT,ExceptCondsrfl/casesproof steps that become automatic🤖 Generated with Claude Code