fix: respect visibility in initialize/builtin_initialize#13239
Open
Kha wants to merge 1 commit intoleanprover:masterfrom
Open
fix: respect visibility in initialize/builtin_initialize#13239Kha wants to merge 1 commit intoleanprover:masterfrom
initialize/builtin_initialize#13239Kha wants to merge 1 commit intoleanprover:masterfrom
Conversation
github-actions
bot
added
the
toolchain-available
Collaborator
|
Reference manual CI status:
|
mathlib-nightly-testing bot
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Apr 1, 2026
github-actions
bot
added
the
mathlib4-nightly-available
mathlib-nightly-testing bot
pushed a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Apr 1, 2026
mathlib-lean-pr-testing
bot
added
the
breaks-mathlib
|
Mathlib CI status (docs):
|
Previously, `elabInitialize` only checked for explicit `private` when deciding whether to mangle `fullId`, ignoring the `module` system's default-private semantics. It also overrode the user's visibility for the generated `initFn` via `visibility.ofBool`. Now, `elabInitialize` uses `elabVisibility` + `isInferredPublic` to correctly handle all visibility contexts. The generated `initFn` inherits the user's visibility rather than being forced public. Also factors out `elabVisibility` from `elabModifiers` for reuse.
mathlib-nightly-testing bot
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Apr 2, 2026
leanprover-bot
added a commit
to leanprover/reference-manual
that referenced
this pull request
Apr 2, 2026
mathlib-nightly-testing bot
pushed a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Apr 2, 2026
leanprover-bot
added
the
builds-manual
|
Mathlib CI status (docs):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where
(builtin_)initializeinsidemodulewould not allow referencing private defs in its type unless explicitly prefixed withprivate.