Fix build- and installation issues + bump GHC and dependencies (blocked by #14)#15
Merged
lazamar merged 3 commits intolazamar:mainfrom Oct 1, 2025
Merged
Fix build- and installation issues + bump GHC and dependencies (blocked by #14)#15lazamar merged 3 commits intolazamar:mainfrom
lazamar merged 3 commits intolazamar:mainfrom
Conversation
carlwr
force-pushed
the
bump-and-freeze
branch
from
be61e87 to
49858ef
Compare
Contributor
Author
|
(I have rebased the commits of this PR onto main after the merge of #14.) |
Owner
|
Thank you so much for this! |
lazamar
requested changes
Oct 1, 2025
Owner
lazamar
left a comment
lazamar
left a comment
There was a problem hiding this comment.
Let's just drop the DEVELOPMENT.md file please.
carlwr
force-pushed
the
bump-and-freeze
branch
from
49858ef to
78e6774
Compare
Contributor
Author
|
You're welcome! No worries; I just pushed a replacement for the last commit that omits |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR stacks on top of #14. Diff for this PR only: carlwr/haskell-docs-cli@fix-win-CI-tests...bump-and-freezeedit: commits for this PR rebased onto main after the merge of #14 into main (ffdbf90)
Fixes #8 and #13.
This great tool is currently a bit tricky to build/install - partly due to all dependency versions free-floating, partly due to an implicit system dependency on a dev version of
zlib(the Github workers running the CI workflow have it, but the machines of many users would not).This PR attempts to stabilize the situation and reduce future maintenance efforts. It makes the builds reproducible through the
cabal.project.freezefile, which picks recently-versioned deps that are compatible with the GHC version that is also bumped to 9.12.2. Thezlibpackage flags incabal.configalso removes the implicit system dependency and instead uses a bundledzlibregardless of platform.I verified that CI still runs successfully, that a test release through the CI action still works, that
cabal build/cabal installsucceeds on a fresh clone (tested on macOS and Ubuntu), and that the updated project loads successfully in HLS.The
Haddock.hsedits refactor away use ofheadandtailsince these cause compiler warnings with the updated GHC version. The refactored expressions should be functionally equivalent to the previous ones.DEVELOPMENT.mdis a pure suggestion - feel free to just skip it.