Fix ASGI middleware crash on streaming responses#261
Open
davidpoblador wants to merge 1 commit intolaurentS:masterfrom
Open
Fix ASGI middleware crash on streaming responses#261davidpoblador wants to merge 1 commit intolaurentS:masterfrom
davidpoblador wants to merge 1 commit intolaurentS:masterfrom
Conversation
send_wrapper was re-sending http.response.start on every body chunk, which breaks streaming responses like FileResponse that send multiple chunks. Now it only sends the start message once.
davidpoblador
force-pushed
the
fix/asgi-middleware-streaming-response
branch
from
0a09dcc to
77fa80b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #260
send_wrapperwas sendinghttp.response.starton every body chunk. For streaming responses likeFileResponse(which send multiplehttp.response.bodymessages withmore_body=True), this causes aRuntimeError: ASGI flow error: Response already startedon the second chunk.The fix just tracks whether we already sent the start message and skips it on subsequent chunks. Headers and status code are still set before the first send, same as before.