ci: fix Consul dev agent startup on Windows CI#412
Draft
devin-ai-integration[bot] wants to merge 3 commits intomainfrom
Draft
ci: fix Consul dev agent startup on Windows CI#412devin-ai-integration[bot] wants to merge 3 commits intomainfrom
devin-ai-integration[bot] wants to merge 3 commits intomainfrom
Conversation
Co-Authored-By: mkeeler@launchdarkly.com <keelerm84@gmail.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
Author
|
@cursor review |
Co-Authored-By: mkeeler@launchdarkly.com <keelerm84@gmail.com>
3 tasks
Point the Windows persistent-stores action at the commit that stops the Consul Windows service before starting the dev agent, replacing the local workaround. See: launchdarkly/gh-actions#77 Co-Authored-By: mkeeler@launchdarkly.com <keelerm84@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
I have added test coverage for new or changed functionality(CI-only change)Related issues
Follow-up to #411, which surfaced a pre-existing flaky failure in the
windows (3.14)CI job. All 52 Consul integration tests fail withconsul.base.ConsulException: 500 No known Consul servers.Upstream fix: launchdarkly/gh-actions#77
Describe the solution you've provided
The
persistent-storesaction installs Consul via chocolatey, which registers it as a Windows service. The action then callsStart-Process consul agent -dev -http-port=8500, but the service may already have bound to port 8500, causing the dev agent to silently fail. This was flaky because the race between the service starting and the dev agent binding was timing-dependent.The fix has been made upstream in the
persistent-storesaction (gh-actions#77), which:choco install, before starting the dev agent.GET /v1/status/leaderfor up to 30 seconds to confirm the agent has completed Raft leader election before the step completes.This PR pins the Windows
persistent-storesreference to the upstream fix commit (0fbe701) so CI can validate the change end-to-end. Once gh-actions#77 is merged and thepersistent-stores-v0tag is updated, this should be switched back to the tag reference.Describe alternatives you've considered
Additional context
Things a reviewer should verify:
0fbe701references an unmerged branch. After gh-actions#77 merges and thepersistent-stores-v0tag is updated, this PR should revert to@persistent-stores-v0.Link to Devin session: https://app.devin.ai/sessions/218fb7de91864819adbc8746029f7331
Requested by: @keelerm84