Skip to content

Fix layout issue with title font sizing in attributed strings #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FelixLisczyk wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix layout issue with title font sizing in attributed strings #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions Sources/UIOnboarding/Views/UIOnboardingTitleLabel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,15 +41,24 @@ extension UIOnboardingTitleLabel {

func updateFontSize(_ fontSize: CGFloat) {
guard let attributedString = attributedText else { return }
let originalFont = font
let mutableAttributedString = NSMutableAttributedString(attributedString: attributedString)

// Update the label's base font
let updatedBaseFont = font.withSize(fontSize)
self.font = updatedBaseFont

// Update fonts in the attributed string
mutableAttributedString.enumerateAttributes(in: NSRange(location: 0,
length: mutableAttributedString.length),
options: []) { attributes, range, _ in
if let font = attributes[.font] as? UIFont {
let multiplier = font.pointSize / (originalFont?.pointSize ?? font.pointSize)
let newFont = font.withSize(fontSize * multiplier)
if let existingFont = attributes[.font] as? UIFont {
// If font is already set in attributed string, preserve relative sizing
let multiplier = existingFont.pointSize / self.font.pointSize
let newFont = existingFont.withSize(fontSize * multiplier)
mutableAttributedString.addAttribute(.font, value: newFont, range: range)
} else {
// If no font is set, apply the base font
mutableAttributedString.addAttribute(.font, value: updatedBaseFont, range: range)
}
}

Expand Down