Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 413ba9210b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (!hashRoutingState.options.interceptInternalLinks || anchor.hasAttribute("download")) { | ||
| return; |
There was a problem hiding this comment.
rewriteAnchorHref canonicalizes every internal a[href] to a hash URL but does not mirror the existing target guard in the click interceptor (target && target !== "_self"). As a result, links intentionally marked with targets like _blank are rewritten anyway, so browser-managed navigation opens the hash-routed SPA URL instead of the original path URL; this changes the behavior of links that were previously used to opt out of interception.
Useful? React with 👍 / 👎.
1 participant
Mutates anchor hrefs attributes to ensure browser links always work.