feat(BA-5589): add integration_name to user entity across all API layers#10786
Merged
HyeockJinKim merged 5 commits intomainfrom Apr 5, 2026
Merged
feat(BA-5589): add integration_name to user entity across all API layers#10786HyeockJinKim merged 5 commits intomainfrom
HyeockJinKim merged 5 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds integration_name support for the user entity end-to-end (DB mapping → data model → DTOs → adapters → filter conditions → GraphQL types/docs), enabling create/update/filter/query behaviors for external identity/integration identifiers.
Changes:
- Added
integration_nameto user data/DTO models and mapped it to the existing DB columnintegration_id. - Implemented filtering support via
UserConditions+ REST/v2 adapter filter conversion. - Updated GraphQL nested/basic types and schema reference docs; added/extended unit tests.
Reviewed changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/unit/manager/repositories/user/test_user_updaters.py | Adds unit tests ensuring updater spec maps integration_name TriState to integration_id. |
| tests/unit/manager/models/user/test_conditions.py | Adds unit tests for integration-name filter SQL generation. |
| tests/unit/manager/api/user/test_adapter.py | Adds adapter filter tests for integration_name. |
| tests/unit/manager/api/adapters/test_user_adapter.py | Adds tests for v2 adapter _user_data_to_node conversion behavior. |
| tests/unit/common/dto/manager/v2/user/test_response.py | Extends v2 response DTO tests to include integration_name. |
| tests/unit/common/dto/manager/v2/user/test_request.py | Extends v2 request/filter DTO tests to include integration_name. |
| src/ai/backend/manager/repositories/user/updaters.py | Adds integration_name to updater spec and maps it to DB integration_id. |
| src/ai/backend/manager/repositories/user/creators.py | Adds integration_name to creator spec and maps it to DB integration_id. |
| src/ai/backend/manager/models/user/row.py | Maps integration_id → integration_name in UserRow.to_data(). |
| src/ai/backend/manager/models/user/conditions.py | Adds integration-name string match conditions over UserRow.integration_id. |
| src/ai/backend/manager/data/user/types.py | Adds integration_name to UserData + row conversion mapping. |
| src/ai/backend/manager/api/rest/user/adapter.py | Adds REST filter conversion for integration_name. |
| src/ai/backend/manager/api/gql/user/types/nested.py | Adds integration_name to GraphQL nested basic info type with version metadata. |
| src/ai/backend/manager/api/gql/user/types/filters.py | Adds integration_name to GraphQL filter input with version metadata. |
| src/ai/backend/manager/api/adapters/user.py | Plumbs integration_name through create/update/filter and node conversion. |
| src/ai/backend/common/dto/manager/v2/user/response.py | Adds integration_name field to v2 response DTO. |
| src/ai/backend/common/dto/manager/v2/user/request.py | Adds integration_name to v2 create/update inputs and filters. |
| src/ai/backend/common/dto/manager/user/request.py | Adds integration_name to v1 filter DTO. |
| docs/manager/graphql-reference/v2-schema.graphql | Updates GraphQL reference schema to include/rename integration-related fields. |
| docs/manager/graphql-reference/supergraph.graphql | Updates supergraph schema reference similarly. |
| changes/10786.feature.md | Adds changelog entry for the new user integration_name field. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
217c7d4 to
31a7a98
Compare
Cover max-length rejection, boundary, sentinel default, none-clear, and value acceptance paths.
7 tasks
HyeockJinKim
approved these changes
Apr 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #10784 (BA-5589)
Add
integration_namefield to the user entity across all layers: data type, row, v2 DTOs (create/update/response/filter), v1 DTO (filter), user conditions (search filter), v1 REST adapter, v2 adapter (create/update/filter/conversion), GQL filter + nested type, GraphQL schema docs, user creators, and user updaters.Checklist: (if applicable)
docsdirectory📚 Documentation preview 📚: https://sorna--10786.org.readthedocs.build/en/10786/
📚 Documentation preview 📚: https://sorna-ko--10786.org.readthedocs.build/ko/10786/