fix(BA-5587): remove re-introduced no-infer-dep comments from processors.py#10780
Draft
fix(BA-5587): remove re-introduced no-infer-dep comments from processors.py#10780
Conversation
github-actions
bot
added
size:L
Contributor
There was a problem hiding this comment.
Pull request overview
Removes reintroduced # pants: no-infer-dep annotations from TYPE_CHECKING imports in the manager services processor registry to restore correct dependency inference and eliminate mypy [import-not-found] errors during pants check.
Changes:
- Removed
# pants: no-infer-depcomments from theTYPE_CHECKINGimport block inservices/processors.py. - Keeps formatting controls (
# fmt: off/on) intact while allowing Pants to infer deps for these type-only imports.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
# pants: no-infer-depcomments from TYPE_CHECKING imports inservices/processors.py2e9e8d95e(feat(BA-4829)) after being removed in019e1551f(fix(BA-4935)), causing 124 mypy[import-not-found]errors onpants checkTest plan
pants check src/ai/backend/manager/services/processors.pypassespants lintpassesResolves BA-5587