Draft
Conversation
Contributor
|
Looks very exciting, thanks @Gusser93!!!
That would be really great! I'm also wondering how to handle the bleak dependency. Maybe make it optional? Maybe we should also make the PyUSB dependency optional? 🤔 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should add support for the Letratag 200B Bluetooth Low Energy Label Maker. For this to work, I made an abstract class
Deviceto support USB and BLE devices. I also put the logic to send the commands in the Device classes instead of the LabelMaker class to allow different workflows for different connections.Will fix #103