Merged
Conversation
kmukherji
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
(timestep, fp_op, component, label, bound)to 9 fields, addingconsistent(bool),triggered_by(Fact/Rule/IPL),meta_name(fact/rule name), andinconsistency_message(descriptive explanation)sickvshealthy) from same-predicate conflicting bounds, and including the specific groundings and bounds involvedConsistent,Triggered By, andInconsistency Messagein the CSV/DataFrame output, making inconsistency resolution fully explainable without parsing free-text stringsqn/qethrough instead of empty lists)inconsistency_example.pydemonstrating node and edge inconsistencies (IPL-based and same-predicate) with the new trace outputtest_inconsistency_trace.py) parameterized across regular, fp, and parallel modes validating the new trace columns[:5]slicing for backward-compatible assertions and adding new assertions for metadata fieldsfilter.pyunpacking to handle the expanded tuple (change[:5])Test plan
test_interpretation_common.py,test_reason_core.py,test_reason_misc.py)test_inconsistency_trace.pypasses across regular, fp, and parallel modesinconsistency_example.pyand verify new columns appear in CSV outputfilter_and_sort_nodes) still work with the expanded tuple🤖 Generated with Claude Code