BroadwayCore foundation types and BRootViewController by kyleve · Pull Request #2 · kyleve/Broadway

kyleve · 2026-03-03T19:07:36Z

Summary

Introduces the foundational type system for BroadwayCore and the root UIKit integration layer in BroadwayUI.

Core primitives:

CopyOnWrite — property wrapper with value-semantic copy-on-write storage (@_spi(Internal) for unsafe access)
AnyEquatable — type-erased equatable box
TypeIdentifier — lightweight type-keyed identifier

Environment system:

BAccessibility — snapshot of UIAccessibility settings with an Observer for live change tracking
BTraits — type-keyed container for environment traits (currently holds BAccessibility)
BThemes — type-keyed container for theme values conforming to BTheme
BStylesheets — lazy, cached stylesheet resolver with transitive dependency support and cycle detection
BContext — root environment container composing traits, themes, and stylesheets

UIKit integration:

BContextTrait UITraitDefinition + UITraitCollection/UIMutableTraits extensions (in BroadwayCore, #if canImport(UIKit))
BRootViewController — container view controller that manages BContext, observes accessibility changes, and propagates context via traitOverrides

Test coverage

~1,600 lines added across 7 test files covering all new types, including stylesheet dependency chains, cycle detection, observer lifecycle, and hosted UI tests (BRootViewControllerTests runs in BroadwayCatalog with @MainActor).

…e DS_Store.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Add BAccessibility struct to represent device accessibility state with a UIKit-backed `current()` factory. Introduce BStylesheet protocol and BStylesheets keyed container. Wire traits and stylesheets into BContext. Remove empty BStylesheet.swift placeholder. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

…ications Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

…yOnWrite Simplify BTraitsValue protocol to require Hashable directly instead of an associated type. Add BAccessibility as a BTraitsValue. Introduce SlicingContext and lazy stylesheet creation in BStylesheets. Add didSet on BContext.traits to clear cached stylesheets. Rename AnyEquatable.value to base. Make CopyOnWrite._unsafeUnderlyingValue setter nonmutating. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

kyleve · 2026-03-29T20:18:02Z

@codex review

BroadwayCore/Sources/BContext.swift

BroadwayCore/Sources/CopyOnWrite.swift

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: eaa544be03

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

BroadwayCore/Sources/BAccessibility.swift

BroadwayCore/Sources/BStylesheets.swift

BroadwayCore/Sources/BAccessibility.swift

Introduce BTheme protocol and BThemes keyed container. Add TypeIdentifier as a debug-friendly wrapper around ObjectIdentifier. Key BStylesheets cache by (stylesheet type, traits, themes) so cached values invalidate when traits or themes change. Add Hashable conformance to CopyOnWrite. Wire themes into BContext with didSet propagation to stylesheets. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Replace preconditionFailure with a throwing CyclicDependencyError that includes the full dependency path. Make BStylesheet.init(context:) and the subscript getter throwing. Move the subscript setter to a separate mutating method since Swift disallows setters on throwing subscripts. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Accept Notification parameter in accessibilityDidChange to match the selector-based addObserver contract. Remove observers per-notification in stop() instead of using blanket removeObserver(self). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Add doc comments to BAccessibility, BContext, BStylesheets, BThemes, BTraits, and TypeIdentifier. Replace the throwing subscript getter and separate set method on BStylesheets with symmetric get/set methods. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

kyleve · 2026-03-29T23:19:53Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9e42f4abaa

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

BroadwayCore/Sources/BStylesheets.swift

BroadwayCore/Sources/BThemes.swift

BroadwayCore/Sources/BTraits.swift

…erlyingValue - BThemes subscript setter now removes the key on nil instead of storing a wrapped Optional.none, avoiding stale dictionary entries. - BStylesheets pulls traits/themes into an internal Config struct so equality only compares configuration, not lazily-populated cache state. Cache and creating stack renamed for clarity. - CopyOnWrite._unsafeUnderlyingValue moved behind @_spi(Internal) so external consumers cannot bypass COW semantics without opting in. Made-with: Cursor

@ViewBuilder

- Define BContextTrait (UITraitDefinition) in BroadwayCore so BContext propagates through UIKit's trait hierarchy automatically. - Add BRootViewController in BroadwayUI: a container VC that owns the root BContext, observes accessibility changes, and writes the context into traitOverrides for child inheritance. - Support both UIViewController children and SwiftUI content via a @ViewBuilder convenience init. - Add public inits to BContext, BTraits, and BThemes so downstream targets can construct them. - Add BRootViewController tests covering init, themes, child containment, and trait propagation. Made-with: Cursor

BroadwayUI/Sources/BRootViewController.swift

kyleve · 2026-03-30T00:29:30Z

BroadwayUI/Sources/BRootViewController.swift

+
+    private var needsContextTraitUpdate : Bool = true
+
+    private func setNeedsContextTraitUpdate() {


Eh what's going on here? This feels sus. Explain why we need this or change it?

…ViewController - BStylesheets.get() now uses defer to unwind the _creating stack, preventing stale cycle-detection entries when a stylesheet init throws. - Fix BTraits.swift file header (was File.swift). - BRootViewController: move child VC containment to init, add subview in viewDidLoad, size child in viewWillLayoutSubviews. - Remove themes parameter from BRootViewController inits (will become an environment parameter). - Replace setNeedsContextTraitUpdate coalescing with a didSet on context that writes traitOverrides directly. Made-with: Cursor

@mainactor

addChild() in BRootViewController.init triggers UIKit key-command updates through UIApplication, which asserts the main thread. Swift Testing runs tests on the cooperative pool by default, so the app host was crashing on every test launch. - Add testHost parameter to the framework() helper in Project.swift and wire BroadwayUITests to BroadwayCatalog. - Annotate BRootViewControllerTests with @mainactor so UIKit calls happen on the main thread. Made-with: Cursor

Made-with: Cursor

@unchecked

Make the full BContext type graph Sendable: trivial conformances on BAccessibility and TypeIdentifier, @unchecked Sendable on CopyOnWrite (where Value: Sendable) and AnyEquatable, and Sendable on BTraits, BThemes, BStylesheets, BContext. Isolate BAccessibility.Observer to @mainactor with a @mainactor @sendable onChange closure. Remove dead BTheme.defaultValue requirement. Add @copyonwrite to BTraits.storage for consistency with BThemes. Made-with: Cursor

New suites: TypeIdentifierTests (6), BTraitsTests (7), BThemesTests (9). Expand BContextTests with self-cycle, 3-node cycle, non-cycle throw, set(), counter-proven invalidation, equality, and propagation tests. Add CopyOnWrite Hashable tests and BRootViewController UITraits roundtrip tests. Total: 55 -> 89 tests. Made-with: Cursor

Use mise exec for tuist test in CI. Fix pre-commit to use xargs -0 for safe filename handling and document working-tree limitation. Fix swiftformat script empty-args crash and positional arg detection. Exclude Derived/ from SwiftFormat. Update AGENTS.md directory layout to reflect current sources. Made-with: Cursor

Made-with: Cursor

kyleve · 2026-03-30T02:36:09Z

BroadwayCore/Sources/BAccessibility.swift

+        }
+    }
+
+    public extension BAccessibility {


Remove public from here, move it down to the types and funcs

Still need to do this

kyleve · 2026-03-30T02:37:22Z

BroadwayCore/Sources/BAccessibility.swift

+                for name in Self.notifications {
+                    NotificationCenter.default.addObserver(
+                        self,
+                        selector: #selector(accessibilityDidChange),


Missing selector argument here

kyleve · 2026-03-30T02:38:48Z

BroadwayCore/Sources/BStylesheets.swift

+    /// Returns the cached stylesheet of the given type, creating it lazily if needed.
+    ///
+    /// - Throws: ``CyclicDependencyError`` if creation triggers a dependency cycle.
+    public func get<Stylesheet: BStylesheet>(_: Stylesheet.Type) throws -> Stylesheet {


Can we make this throw a typed error?

kyleve · 2026-03-30T02:42:29Z

BroadwayCore/Sources/BStylesheets.swift

+
+    /// Explicitly sets a cached stylesheet value for the given type,
+    /// replacing any previously cached instance for the current traits and themes.
+    public mutating func set<Stylesheet: BStylesheet>(_ newValue: Stylesheet) {


Does this need to be public?

kyleve · 2026-03-30T02:45:03Z

BroadwayCore/Sources/BThemes.swift

+            let id = TypeIdentifier(Theme.self)
+
+            guard let value = themes[id], let value = value.base as? Theme else {
+                return nil


This should be returning a defaultValue

BroadwayCore/Sources/BThemes.swift

BroadwayUI/Sources/BRootViewController.swift

kyleve · 2026-03-30T02:48:57Z

BroadwayUI/Sources/BRootViewController.swift

+        override public func viewDidLoad() {
+            super.viewDidLoad()
+
+            view.addSubview(child.view)


Should set the frame before adding the subview

kyleve · 2026-03-30T02:50:03Z

BroadwayUI/Tests/BRootViewControllerTests.swift

+        @Test("Context traits reflect the live accessibility snapshot")
+        func contextHasLiveAccessibility() {
+            let vc = BRootViewController(child: UIViewController())
+            #expect(vc.context.traits.accessibility == BAccessibility.current())


This test sucks for a couple reasons:

Not in the view controller hierarchy

Not waiting for that VC hierarchy to be loaded.

Hold on, I'll get this going soon. Don't address yet.

kyleve · 2026-03-30T02:50:55Z

ide

 #!/bin/bash
 set -euo pipefail

+git config core.hooksPath .githooks


Is putting this here right? Is this also what ensures CI gets set up? Should we split this out into something CI runs too so we can ensure CI runs the formatter? Thoughts?

- BThemes: restore defaultValue on BTheme protocol, make subscript non-optional, canonicalize storage by removing default entries - BStylesheets: replace CyclicDependencyError with typed StylesheetError enum (cyclicDependency/creationFailed), make set() internal - BContext: add equality guards in traits/themes didSet, create fresh BStylesheets on change to fix COW isolation, improve doc comments - AnyEquatable: capture shared base in closure to avoid double-retention - BAccessibility: move public from extension to members, loop deinit removals, use explicit selector form, improve observeChanges doc - BContext+UITraits: improve bContext doc comment - BRootViewController: move observer start to viewDidLoad, set child frame before addSubview - Update all tests for defaultValue, StylesheetError, and non-optional theme subscripts Made-with: Cursor

kyleve · 2026-03-30T03:29:27Z

@codex review

kyleve · 2026-03-30T03:33:29Z

BroadwayCore/Sources/BAccessibility.swift

+                old = nil
+            }
+
+            deinit {


This entire thing can go away; deinit does this automatically.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c957e5e371

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-03-30T03:33:50Z

.githooks/pre-commit

+  | xargs -0 --no-run-if-empty mise exec -- swiftformat
+
+git diff --cached --name-only --diff-filter=ACMR -z -- '*.swift' \
+  | xargs -0 --no-run-if-empty git add


Remove GNU-only xargs flag from pre-commit hook

The new hook uses xargs --no-run-if-empty in both pipelines, but that long option is GNU-specific and is rejected by BSD xargs on macOS (the default environment for iOS development). With set -euo pipefail, this causes the hook to exit non-zero and blocks commits before formatting/staging runs. Please switch to a macOS-compatible invocation (or a portable conditional) so contributors can commit normally.

Useful? React with 👍 / 👎.

BroadwayCore/Sources/BAccessibility.swift

kyleve · 2026-03-30T03:41:07Z

BroadwayCore/Sources/BStylesheets.swift

+    init(context: SlicingContext) throws
+}
+
+/// Errors thrown by ``BStylesheets/get(_:)`` during stylesheet resolution.


Let's move this to a new file

kyleve · 2026-03-30T03:46:16Z

BroadwayCore/Sources/BThemes.swift

+        set {
+            let id = TypeIdentifier(Theme.self)
+
+            if newValue == Theme.defaultValue {


This seems wrong, why not just set the value? What's the benefit of setting it to nil?

The input isn't nullable, so you shouldn't be either!

If we want to allow nullable here, (aka resetting to the default), let's switch this into two separate get and set methods

kyleve · 2026-03-30T03:49:59Z

BroadwayCore/Sources/BThemes.swift

+
+    /// Gets or sets the theme for the given type. Returns
+    /// ``BTheme/defaultValue`` if no value has been explicitly set.
+    public subscript<Theme: BTheme>(_: Theme.Type) -> Theme {


Can we remove the _: here?

kyleve · 2026-03-30T04:04:34Z

BroadwayUI/Sources/BRootViewController.swift

+            context.traits.accessibility = .current()
+            traitOverrides.bContext = context
+
+            accessibilityObserver = BAccessibility.observeChanges { [weak self] _, new in


Let's move this into viewDidLoad

kyleve · 2026-03-30T04:06:46Z

AGENTS.md

Can we simplify this and the README? No need to enumerate every file, just explain folders that matter. Simplify the folder explanation!

kyleve · 2026-03-30T04:07:52Z

swiftformat

For my own education, please comment this file with what each line does!

- Add notificationCenter parameter to Observer.init and observeChanges factory, defaulting to .default, for test isolation - Remove explicit deinit (NotificationCenter auto-removes on dealloc) - Configure SwiftFormat --extension-acl on-declarations; public now lives on individual members rather than extensions - Fix pre-commit hook: replace GNU --no-run-if-empty with portable empty-input guard - Add 4 new observer tests exercising injected NotificationCenter Made-with: Cursor

New framework target for shared test utilities. All test targets depend on it automatically. Includes XCTestCaseAdditions from Listable for view controller presentation and runloop helpers. Made-with: Cursor

Minimal app with an empty window that serves as the test host for BroadwayCoreTests and BroadwayUITests, replacing the previous setup where BroadwayUI used BroadwayCatalog and BroadwayCore had no host. Simplifies the framework() helper by removing the testHost parameter. Made-with: Cursor

Made-with: Cursor

kyleve and others added 10 commits March 3, 2026 09:52

Add initial version of CopyOnWrite struct. Update gitignore to includ…

c604406

…e DS_Store.

Add initial core types

de7c92b

Add documentation and tests for CopyOnWrite

e321325

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Add documentation and tests for AnyEquatable

662d9e3

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Add accessibility Observer and alphabetize init, current(), and notif…

01b805f

…ications Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Add tests for BAccessibility

dbc7fc6

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Update AGENTS.md with mise exec prefix and per-scheme test instructions

df579df

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Add Observer lifecycle and notification tests to BAccessibilityTests

5e64717

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

kyleve commented Mar 29, 2026

View reviewed changes

BroadwayCore/Sources/BContext.swift Outdated Show resolved Hide resolved

BroadwayCore/Sources/CopyOnWrite.swift Outdated Show resolved Hide resolved

chatgpt-codex-connector bot reviewed Mar 29, 2026

View reviewed changes

BroadwayCore/Sources/BAccessibility.swift Outdated Show resolved Hide resolved

BroadwayCore/Sources/BStylesheets.swift Outdated Show resolved Hide resolved

kyleve commented Mar 29, 2026

View reviewed changes

BroadwayCore/Sources/BAccessibility.swift Outdated Show resolved Hide resolved

kyleve and others added 5 commits March 29, 2026 18:29

Add BContext stylesheet tests including dependency chains

d1ce432

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

chatgpt-codex-connector bot reviewed Mar 29, 2026

View reviewed changes

BroadwayCore/Sources/BStylesheets.swift Outdated Show resolved Hide resolved

BroadwayCore/Sources/BThemes.swift Outdated Show resolved Hide resolved

kyleve commented Mar 29, 2026

View reviewed changes

BroadwayCore/Sources/BTraits.swift Outdated Show resolved Hide resolved

kyleve added 2 commits March 29, 2026 19:54

kyleve commented Mar 30, 2026

View reviewed changes

BroadwayUI/Sources/BRootViewController.swift Outdated Show resolved Hide resolved

kyleve commented Mar 30, 2026

View reviewed changes

kyleve added 2 commits March 29, 2026 20:45

kyleve changed the title ~~[WIP DNR] Core types~~ BroadwayCore foundation types and BRootViewController Mar 30, 2026

kyleve force-pushed the kve/base-infra branch from e9d8a75 to 760b28e Compare March 30, 2026 01:31

kyleve added 5 commits March 29, 2026 21:55

Run SwiftFormat on all Swift sources

b3a6639

Made-with: Cursor

Pre-commit hook: auto-format and re-stage instead of lint-only

74bbefe

Made-with: Cursor

kyleve commented Mar 30, 2026

View reviewed changes

BroadwayCore/Sources/BThemes.swift Outdated Show resolved Hide resolved

kyleve commented Mar 30, 2026

View reviewed changes

BroadwayUI/Sources/BRootViewController.swift Outdated Show resolved Hide resolved

kyleve commented Mar 30, 2026

View reviewed changes

chatgpt-codex-connector bot reviewed Mar 30, 2026

View reviewed changes

kyleve commented Mar 30, 2026

View reviewed changes

BroadwayCore/Sources/BAccessibility.swift Show resolved Hide resolved

kyleve commented Mar 30, 2026

View reviewed changes

swiftformat

Copy link
Copy Markdown

Owner Author

kyleve Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my own education, please comment this file with what each line does!

kyleve added 4 commits March 30, 2026 00:15

Add BroadwayTesting module with XCTestCase utilities

8cbfc76

New framework target for shared test utilities. All test targets depend on it automatically. Includes XCTestCaseAdditions from Listable for view controller presentation and runloop helpers. Made-with: Cursor

TestHost: remove BroadwayUI dependency, convert to UIKit AppDelegate

e820eab

Made-with: Cursor


		private var needsContextTraitUpdate : Bool = true

		private func setNeedsContextTraitUpdate() {

Conversation

kyleve commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test coverage

Uh oh!

kyleve commented Mar 29, 2026

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kyleve commented Mar 29, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kyleve commented Mar 30, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kyleve Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

kyleve commented Mar 3, 2026 •

edited

Loading

kyleve Mar 30, 2026 •

edited

Loading