WIP Migrate KKP dashboard auth from implicit flow to OAuth authorization code flow#7960
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@ahmadhamzh: Adding the "do-not-merge/docs-needed" label because no documentation block was detected, please follow our documentation process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| -address=127.0.0.1:8080 \ | ||
| -oidc-url=https://dev.kubermatic.io/dex \ | ||
| -oidc-authenticator-client-id=kubermatic \ | ||
| -oidc-authenticator-client-id=kubermaticIssuer \ |
There was a problem hiding this comment.
Changed -oidc-authenticator-client-id from kubermatic to kubermaticIssuer
because the new auth code flow issues tokens using the issuer client (kubermaticIssuer).
The token verifier must use the same client ID to accept these tokens (audience claim must match).
The old kubermatic public client was only needed for the implicit flow which is being removed.
4b397b3 to
7ab549f
Compare
|
@ahmadhamzh: The following tests failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #7940
What type of PR is this?
/kind design
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: