Skip to content

fix: handle azure platform in metrics service factory#222

Open
KUNDAN1334 wants to merge 1 commit intokubeflow:mainfrom
KUNDAN1334:Error-for-centraldashboard
Open

fix: handle azure platform in metrics service factory#222
KUNDAN1334 wants to merge 1 commit intokubeflow:mainfrom
KUNDAN1334:Error-for-centraldashboard

Conversation

@KUNDAN1334
Copy link
Copy Markdown

Closes #194

Fix
Added an explicit case 'azure': branch that:

Logs a clear console.info (not warn) explaining that metrics are intentionally disabled on Azure and directs users to Prometheus as the appropriate alternative
Returns null explicitly, making the intent clear rather than falling through

case 'azure':
  console.info('"azure" platform detected. Metrics disabled (use Prometheus for AKS).');
  return null;

Test

Added a regression test to metrics_service_factory_test.ts that:

  • Simulates an AKS cluster with a real Azure providerID format
  • Asserts getMetricsService() returns null
  • Asserts console.warn is never called — this is the critical guard that would catch any future regression back to the old behaviour
image

@google-oss-prow google-oss-prow bot added the area/dashboard area - related to central dashboard label Feb 23, 2026
@google-oss-prow
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign thesuperzapper for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: KUNDAN1334 <kundan.22bcon1334@jecrcu.edu.in>
@KUNDAN1334 KUNDAN1334 force-pushed the Error-for-centraldashboard branch from c0cad2e to 738f705 Compare February 23, 2026 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/dashboard area - related to central dashboard size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error for centraldashboard: "azure" is not a supported platform for Metrics

1 participant