fix: handle azure platform in metrics service factory#222
Open
KUNDAN1334 wants to merge 1 commit intokubeflow:mainfrom
Open
fix: handle azure platform in metrics service factory#222KUNDAN1334 wants to merge 1 commit intokubeflow:mainfrom
KUNDAN1334 wants to merge 1 commit intokubeflow:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-off-by: KUNDAN1334 <kundan.22bcon1334@jecrcu.edu.in>
c0cad2e to
738f705
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #194
Fix
Added an explicit case 'azure': branch that:
Logs a clear console.info (not warn) explaining that metrics are intentionally disabled on Azure and directs users to Prometheus as the appropriate alternative
Returns null explicitly, making the intent clear rather than falling through
Test
Added a regression test to
metrics_service_factory_test.tsthat:providerIDformatgetMetricsService()returnsnullconsole.warnis never called — this is the critical guard that would catch any future regression back to the old behaviour