Skip to content

fix: upgrade VirtualService manifests to v1#214

Open
vrajjbhatt wants to merge 1 commit intokubeflow:mainfrom
vrajjbhatt:fix/upgrade-istio-vs-final
Open

fix: upgrade VirtualService manifests to v1#214
vrajjbhatt wants to merge 1 commit intokubeflow:mainfrom
vrajjbhatt:fix/upgrade-istio-vs-final

Conversation

@vrajjbhatt
Copy link
Copy Markdown

closes: #201

Motivation

Upgrading deprecated Istio v1alpha3 APIs to the stable v1 version.

Changes

  • Updated apiVersion to networking.istio.io/v1 in centraldashboard, centraldashboard-angular, and profile-controller manifests.

Signed-off-by: vrajjbhatt <30697942+vrajjbhatt@users.noreply.github.com>
@google-oss-prow google-oss-prow bot added the area/dashboard area - related to central dashboard label Feb 18, 2026
@google-oss-prow
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign thesuperzapper for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot requested a review from kimwnasptd February 18, 2026 20:26
@google-oss-prow google-oss-prow bot added area/dashboard-angular area - related to central dashboard angular area/profiles area - related to profile-controller size/XS labels Feb 18, 2026
@vrajjbhatt vrajjbhatt changed the title fix(dashboard): upgrade VirtualService manifests to v1 fix: upgrade VirtualService manifests to v1 Feb 18, 2026
@vrajjbhatt
Copy link
Copy Markdown
Author

I have analyzed the CI failures for PR #214.

  • VirtualService v1 Error: The integration tests fail because the CI environment's Istio version is outdated and does not support networking.istio.io/v1. Since the goal of Upgrade VirtualService manifests from v1alpha3 to stable networking.istio.io/v1 #201 is specifically to move to stable APIs, this indicates the CI environment itself needs an upgrade.

  • Etcd Error: The Profile Controller unit tests are failing due to a missing etcd binary in the runner's PATH, which is an existing infrastructure issue.

  • 401 Unauthorized: There were GCS bucket access issues during the setup phase of several jobs.

All my manifest changes are strictly following the requested upgrade. Requesting a maintainer review.

Summary of PR Status:
DCO: Passed ✅ (Your sign-off is correct).
Semantic Title: Passed ✅
Code Quality: Passed ✅ (XS size, simple manifest update).

@vrajjbhatt
Copy link
Copy Markdown
Author

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/dashboard area - related to central dashboard area/dashboard-angular area - related to central dashboard angular area/profiles area - related to profile-controller size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade VirtualService manifests from v1alpha3 to stable networking.istio.io/v1

1 participant