Skip to content

feat: add AllocT template parameter to HashMap and HashSet#76

Open
tarun-t wants to merge 1 commit intoktprime:masterfrom
tarun-t:feature/allocator-support
Open

feat: add AllocT template parameter to HashMap and HashSet#76
tarun-t wants to merge 1 commit intoktprime:masterfrom
tarun-t:feature/allocator-support

Conversation

@tarun-t
Copy link

@tarun-t tarun-t commented Mar 21, 2026

Adds a defaulted AllocT template parameter to all HashMap (5/6/7/8) and HashSet (2/3/4/8), replacing hardcoded malloc/free with allocator_traits. Fixes alignment for over-aligned value types. Backwards compatible.

Closes #39

Add a defaulted allocator template parameter to all HashMap (5/6/7/8)
and HashSet (2/3/4/8) variants, replacing hardcoded malloc/free with
allocator_traits calls. Fixes alignment for over-aligned value types.

Closes ktprime#39
@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the emhash library by introducing customizable memory allocation for its hash map and hash set containers. By replacing direct malloc/free calls with std::allocator_traits, the library now supports user-defined allocators, which is crucial for applications requiring fine-grained control over memory, such as memory pooling or specific alignment requirements. This change also addresses and corrects memory alignment for complex data types, ensuring robustness and performance, all while maintaining backward compatibility with existing codebases.

Highlights

  • Custom Allocator Support: Introduced a defaulted AllocT template parameter to all HashMap (5/6/7/8) and HashSet (2/3/4/8) implementations, allowing users to provide custom memory allocators.
  • Memory Management Modernization: Replaced hardcoded malloc/free calls with std::allocator_traits for all memory allocations and deallocations, enhancing flexibility and adherence to C++ allocator conventions.
  • Alignment Correction: Implemented logic to correctly handle and fix alignment for over-aligned value types within the hash containers.
  • Allocator-Aware Constructors and Operators: Added new constructors and assignment operators that accept allocator arguments and correctly implement allocator propagation rules (e.g., select_on_container_copy_construction, propagate_on_container_copy_assignment).
  • Comprehensive Testing: Added a new test file (test/test_allocator.cpp) to thoroughly verify the new allocator functionality, including tests for default allocators, over-aligned types, std::pmr allocators, and allocator propagation behavior.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces std::allocator support across all emhash hash set and hash map containers. The changes involve updating class templates to accept an AllocT parameter, replacing raw malloc/free calls with allocator-aware alloc_bucket/dealloc_bucket methods, and modifying constructors, copy/move constructors, and assignment operators to correctly handle allocator construction, propagation, and assignment. Additionally, get_allocator() methods were added, and a new test file (test/test_allocator.cpp) was included to verify the new allocator functionality, including std::pmr allocators and their propagation behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add the fifth template parameter _Alloc

1 participant