This repository was archived by the owner on Dec 16, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 498
Added method Socket::shutdown() #845
Open
sirsnyder
wants to merge
5
commits into
master
Choose a base branch
from
socket_shutdown
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
d4c9931
Added optional method Socket::shutdown()
sirsnyder bc9f34d
Improvements & fixes for Socket::shutdown() PR (#864)
dktapps 16e0e6a
Merge branch 'master' into socket_shutdown
sirsnyder f1641c3
test modified
sirsnyder 82444c4
skip online test
sirsnyder File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| --TEST-- | ||
| Test of Socket::shutdown() - testing params and separate shutdown of read and write channel | ||
| --SKIPIF-- | ||
| <?php | ||
| if(getenv("SKIP_ONLINE_TESTS")) die("skip online test"); | ||
| if(!method_exists(\Socket::class, 'shutdown')) { | ||
| die('skip.. Socket::shutdown() doesn\'t exist'); | ||
| } | ||
| --FILE-- | ||
| <?php | ||
| $socket = new \Socket(\Socket::AF_INET, \Socket::SOCK_STREAM, \Socket::SOL_TCP); | ||
|
|
||
| try{ | ||
| $socket->shutdown(4); // invalid | ||
| }catch(\InvalidArgumentException $e){ | ||
| var_dump($e->getMessage()); | ||
| } | ||
|
|
||
| try { | ||
| var_dump($socket->shutdown(\Socket::SHUTDOWN_READ)); // close reading | ||
| } catch(Exception $exception) { var_dump('not connected'); } | ||
|
|
||
| $socket->connect('www.php.net', 80); | ||
|
|
||
| var_dump($socket->shutdown(\Socket::SHUTDOWN_READ)); // close reading | ||
| var_dump($socket->shutdown(\Socket::SHUTDOWN_WRITE)); // close writing | ||
|
|
||
| $socket->close(); | ||
| ?> | ||
| --EXPECT-- | ||
| string(21) "Invalid shutdown type" | ||
| string(13) "not connected" | ||
| bool(true) | ||
| bool(true) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where is this macro defined?never mind