update ffi-cdecl + some related fixups#2325
Merged
Frenzie merged 9 commits intokoreader:masterfrom Apr 5, 2026
Merged
Conversation
Even on macOS, it's compiled to a `.so`.
When building for the emulator, to avoid potential dynamic linker path issues at runtime (e.g. on macOS when using Homebrew's GCC).
To build only those projects necessary for generating FFI cdecls.
Don't enable by default on kindle-legacy (toolchain `dev_t` type definition is borked).
Enable for Kobo targets, not Kindle…
Member
Is that just what GCC does or is that technically an oversight in ffi-cdecl? |
Member
Author
|
The gcc-lua build system does not special case macOS, I don't thing GCC care about the extension. |
Frenzie
reviewed
Apr 4, 2026
| -e "s,@CXX@,${CMAKE_CXX_COMPILER}," | ||
| -e "s,@PREFIX@,${STAGING_DIR}," | ||
| -e "s,@PLUGIN@,${STAGING_DIR}/lib/gcc/plugin/gcclua${LIB_EXT}," | ||
| -e "s,@PLUGIN@,${STAGING_DIR}/lib/gcc/plugin/gcclua.so," |
Member
There was a problem hiding this comment.
Does this context allow for comments? Seeing this would make me think it was an oversight.
Member
Author
There was a problem hiding this comment.
Yes, but it's also not the only instance where we always create a .so, even on macOS (koreader-lfs, lpeg, luasocket, luasec, lua-rapidjson).
benoit-pierre
added a commit
to benoit-pierre/koreader
that referenced
this pull request
Apr 5, 2026
- openssh: update to 10.3p1 (koreader/koreader-base#2323) - cmake: misc tweaks (koreader/koreader-base#2324) - update ffi-cdecl + some related fixups (koreader/koreader-base#2325)
Frenzie
pushed a commit
to koreader/koreader
that referenced
this pull request
Apr 5, 2026
- openssh: update to 10.3p1 (koreader/koreader-base#2323) - cmake: misc tweaks (koreader/koreader-base#2324) - update ffi-cdecl + some related fixups (koreader/koreader-base#2325)
Saterz
pushed a commit
to Saterz/koreader
that referenced
this pull request
Apr 6, 2026
- openssh: update to 10.3p1 (koreader/koreader-base#2323) - cmake: misc tweaks (koreader/koreader-base#2324) - update ffi-cdecl + some related fixups (koreader/koreader-base#2325)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is