pocketbook: add GetGlobalConfig, ReadString#2317
Merged
Frenzie merged 1 commit intokoreader:masterfrom Mar 30, 2026
Merged
Conversation
A prerequisite for fixing koreader/koreader#15178: KOReader sets the book cover as PocketBook boot logo unconditionally. We should only do that if the user requested this. The best UX that I can think of is to just respect what's set in the system settings (Personalize → Logos → Boot Logo). See the issue for more details and the proposed fix (as a user patch).
Frenzie
approved these changes
Mar 30, 2026
Member
Frenzie
left a comment
Frenzie
left a comment
There was a problem hiding this comment.
lgtm, but pinging @benoit-pierre to double check if it interacts correctly with the new structure
benoit-pierre
approved these changes
Mar 30, 2026
benoit-pierre
pushed a commit
to benoit-pierre/koreader
that referenced
this pull request
Mar 31, 2026
) A prerequisite for fixing koreader#15178: KOReader sets the book cover as PocketBook boot logo unconditionally. We should only do that if the user requested this. The best UX that I can think of is to just respect what's set in the system settings (Personalize → Logos → Boot Logo). See the issue for more details and the proposed fix (as a user patch).
benoit-pierre
added a commit
to benoit-pierre/koreader
that referenced
this pull request
Apr 1, 2026
- sdl: rework library detection / version check (koreader/koreader-base#2309) - djvulibre: update to 3.5.29-3-gfd7b8db (koreader/koreader-base#2310) - freetype2: update to 2.14.3 (koreader/koreader-base#2311) - luajit: update to 2.1.1774638290 (koreader/koreader-base#2312) - libpng: update to 1.6.56 (koreader/koreader-base#2313) - libjpeg-turbo: update to 3.1.4.1 (koreader/koreader-base#2314) - switch to miniconv (koreader/koreader-base#2315) - sdl: update to 3.4.2 (koreader/koreader-base#2316) - pocketbook: add GetGlobalConfig, ReadString (koreader/koreader-base#2317) - pocketbook: fix support for inkview 6.0-6.10 (koreader/koreader-base#2318) - luajit: update to 2.1.1774896198 (koreader/koreader-base#2319) - xz: update to 5.8.3 (koreader/koreader-base#2320) - sqlite: add download mirrors (koreader/koreader-base#2321)
Frenzie
pushed a commit
to koreader/koreader
that referenced
this pull request
Apr 1, 2026
- sdl: rework library detection / version check (koreader/koreader-base#2309) - djvulibre: update to 3.5.29-3-gfd7b8db (koreader/koreader-base#2310) - freetype2: update to 2.14.3 (koreader/koreader-base#2311) - luajit: update to 2.1.1774638290 (koreader/koreader-base#2312) - libpng: update to 1.6.56 (koreader/koreader-base#2313) - libjpeg-turbo: update to 3.1.4.1 (koreader/koreader-base#2314) - switch to miniconv (koreader/koreader-base#2315) - sdl: update to 3.4.2 (koreader/koreader-base#2316) - pocketbook: add GetGlobalConfig, ReadString (koreader/koreader-base#2317) - pocketbook: fix support for inkview 6.0-6.10 (koreader/koreader-base#2318) - luajit: update to 2.1.1774896198 (koreader/koreader-base#2319) - xz: update to 5.8.3 (koreader/koreader-base#2320) - sqlite: add download mirrors (koreader/koreader-base#2321)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A prerequisite for fixing koreader/koreader#15178:
KOReader sets the book cover as PocketBook boot logo unconditionally. We should only do that if the user requested this. The best UX that I can think of is to just respect what's set in the system settings (Personalize → Logos → Boot Logo).
See the issue for more details and the proposed fix (as a user patch).
This change is