Skip to content

fix gradle deprecation warning#571

Merged
Frenzie merged 1 commit intokoreader:masterfrom
benoit-pierre:pr/fix_gradle_deprecation_warning
Sep 28, 2025
Merged

fix gradle deprecation warning#571
Frenzie merged 1 commit intokoreader:masterfrom
benoit-pierre:pr/fix_gradle_deprecation_warning

Conversation

@benoit-pierre
Copy link
Copy Markdown
Member

@benoit-pierre benoit-pierre commented Sep 28, 2025

WARNING: The option setting 'android.defaults.buildfeatures.buildconfig=true' is deprecated.
The current default is 'false'.
It will be removed in version 9.0 of the Android Gradle plugin.

And remove other deprecated gradle properties already defaulting to false (cf. https://developer.android.google.cn/reference/tools/gradle-api/8.6/com/android/build/api/dsl/BuildFeatures).


This change is Reviewable

```
WARNING: The option setting 'android.defaults.buildfeatures.buildconfig=true' is deprecated.
The current default is 'false'.
It will be removed in version 9.0 of the Android Gradle plugin.
```

And remove other deprecated gradle properties already defaulting to false
(cf. https://developer.android.google.cn/reference/tools/gradle-api/8.6/com/android/build/api/dsl/BuildFeatures).
@Frenzie
Copy link
Copy Markdown
Member

Frenzie commented Sep 28, 2025

If you're more at home with Android than I am and/or more interested in the subject (I find Android tedious), please feel free to incorporate aspects of #572. ;-) I should probably limit that one to just the code change.

@Frenzie Frenzie merged commit fba2aa2 into koreader:master Sep 28, 2025
3 checks passed
@benoit-pierre benoit-pierre deleted the pr/fix_gradle_deprecation_warning branch December 11, 2025 16:53
benoit-pierre added a commit to benoit-pierre/koreader that referenced this pull request Dec 13, 2025
```
WARNING: The option setting 'android.defaults.buildfeatures.buildconfig=true' is deprecated.
The current default is 'false'.
It will be removed in version 9.0 of the Android Gradle plugin.
```

And remove other deprecated gradle properties already defaulting to false
(cf. https://developer.android.google.cn/reference/tools/gradle-api/8.6/com/android/build/api/dsl/BuildFeatures).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants