add setImmersiveFullscreen to toggle navbar in android#380
Open
vanadium23 wants to merge 1 commit intokoreader:masterfrom
Open
add setImmersiveFullscreen to toggle navbar in android#380vanadium23 wants to merge 1 commit intokoreader:masterfrom
vanadium23 wants to merge 1 commit intokoreader:masterfrom
Conversation
Member
|
Hey, @vanadium23, thanks for your time! Looks good. Could you please send a PR against the main repo before this gets merged?. I would like to see the whole picture and do some quick tests |
pazos
reviewed
Sep 4, 2022
Author
|
@pazos add pull request to koreader: koreader/koreader#9485 |
vanadium23
force-pushed
the
feature/toogle-navbar-in-immersive-mode
branch
from
1f0919b to
2d073dd
Compare
Contributor
|
What is blocking this PR? |
Member
Contributor
|
I get that the main integration PR has some unresolved issues, but none of those suggested to me that the code in this repo isn't ready to merge. |
Member
|
Is there something more specific you're trying to ask? Even if there were no merge conflicts untested code is broken code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, koreader team.
I really miss navbar on my android tablet, and want to add back the feature to toggle full screen.
This is first part, just to add proper function, second one will be done within original repo.
Original issue koreader/koreader#8532.
This change is