Merged
Conversation
Owner
|
Cool! What OS are you running on? Yours was slightly faster on those tests, whereas when I run it (WSL2 Windows 11 i7-12700H, conda environment) it's slightly slower as below. (EDIT: sorry, only skimmed table. Looks similar, with yours generally having a slight edge)
Re merging, I was going to but had a look at https://github.com/phoboslab/qoi and there are 3 other python libs (not including yours), so if I was going to include yours I should probably include theirs. Thoughts? |
Contributor
Author
|
I'm running on native Arch Linux. Aren't the other libraries written in python? I doubt they have similar performance. I don't really care if you merge this, or add the others. I just was curious and added my library to your benchmark, and thought I could share it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made my one library because I'm not in the numpy ecosystem and wanted an alternative using more normal python datatypes. Performance seems to be similar.