Dont pop items from dicts obscure sideffect#27
Open
blaggacao wants to merge 8 commits intoknowark:masterfrom
Open
Dont pop items from dicts obscure sideffect#27blaggacao wants to merge 8 commits intoknowark:masterfrom
blaggacao wants to merge 8 commits intoknowark:masterfrom
Conversation
added 8 commits
December 14, 2018 15:00
As a side-effect, get rid of (deprecated) pyOpenSSL dependency. Rather provide the library with a standard pem certificate. Maybe support DER binary format one day?
Instead run on a copy of the originally passed dict. It is generally not expected (unless declared as receiver) for a method to manipulate passed mutable datastructrues in place.
Contributor
Author
|
@tebanep This is a no-brainer (only last commit, as the rest is carried from the other PRs) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead run on a copy of the originally passed dict.
It is generally not expected (unless declared as receiver) for a method to
manipulate passed mutable datastructrues in place.