[FIX] include required assets (xsd & pdf)#22
[FIX] include required assets (xsd & pdf)#22blaggacao wants to merge 1 commit intoknowark:masterfrom
Conversation
|
@tebanep Is this a proper fix or would you prefer to remove the (heavy) PDFs from the library? |
250e217 to
97facb9
Compare
Codecov Report
@@ Coverage Diff @@
## master #22 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 94 94
Lines 1954 1954
Branches 96 96
=====================================
Hits 1954 1954Continue to review full report at Codecov.
|
Precisely because of transparency as you point it up. A cached value could make it as well, but it would 'hide' what the comparison is actually doing. 2mb doesn't seem like a lot in 2TB server ;) |
|
After this pathc, I cand jump to the next hop: I hope I find a fix quickly for this, too... 😉 Still some hops on this side. |
|
@blaggacao Should I merge this already? |
|
|
97facb9 to
60c3c94
Compare
|
@tebanep That one seems good now. |
@tebanep
Towards #18 (comment)
However, I wonder why the pdf sources have to be included to calculate their hash value instead of just including the hash value. It's very transparent (and the whole truth), but maybe saving on those 2MBs would be worth a thought?