Skip to content

[FIX] include required assets (xsd & pdf)#22

Open
blaggacao wants to merge 1 commit intoknowark:masterfrom
xoe-labs:fix-bundled-assets
Open

[FIX] include required assets (xsd & pdf)#22
blaggacao wants to merge 1 commit intoknowark:masterfrom
xoe-labs:fix-bundled-assets

Conversation

@blaggacao
Copy link
Copy Markdown
Contributor

@blaggacao blaggacao commented Dec 14, 2018

@tebanep

Towards #18 (comment)

However, I wonder why the pdf sources have to be included to calculate their hash value instead of just including the hash value. It's very transparent (and the whole truth), but maybe saving on those 2MBs would be worth a thought?

@blaggacao
Copy link
Copy Markdown
Contributor Author

@tebanep Is this a proper fix or would you prefer to remove the (heavy) PDFs from the library?

@blaggacao blaggacao force-pushed the fix-bundled-assets branch 2 times, most recently from 250e217 to 97facb9 Compare December 14, 2018 15:30
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 14, 2018

Codecov Report

Merging #22 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #22   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          94     94           
  Lines        1954   1954           
  Branches       96     96           
=====================================
  Hits         1954   1954

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50cbf98...60c3c94. Read the comment docs.

@tebanep
Copy link
Copy Markdown
Contributor

tebanep commented Dec 14, 2018

@tebanep

Towards #18 (comment)

However, I wonder why the pdf sources have to be included to calculate their hash value instead of just including the hash value. It's very transparent (and the whole truth), but maybe saving on those 2MBs would be worth a thought?

Precisely because of transparency as you point it up. A cached value could make it as well, but it would 'hide' what the comparison is actually doing. 2mb doesn't seem like a lot in 2TB server ;)

@blaggacao
Copy link
Copy Markdown
Contributor Author

After this pathc, I cand jump to the next hop:

odoo_1      | I/O warning : failed to load external entity "/usr/local/lib/python3.5/dist-packages/facturark/XSD/DIAN/UBL2/common/UBL-CommonAggregateComponents-2.0.xsd"
odoo_1      | I/O warning : failed to load external entity "/usr/local/lib/python3.5/dist-packages/facturark/XSD/DIAN/UBL2/common/UBL-CommonBasicComponents-2.0.xsd"
odoo_1      | I/O warning : failed to load external entity "/usr/local/lib/python3.5/dist-packages/facturark/XSD/DIAN/UBL2/common/UBL-CommonExtensionComponents-2.0.xsd"
odoo_1      | error : Unknown IO error
odoo_1      | I/O warning : failed to load external entity "http://www.dian.gov.co/micrositios/fac_electronica/documentos/common/UnqualifiedDataTypeSchemaModule-2.0.xsd"
odoo_1      | error : Unknown IO error
odoo_1      | I/O warning : failed to load external entity "http://www.dian.gov.co/micrositios/fac_electronica/documentos/common/UBL-CommonAggregateComponents-2.0.xsd"

I hope I find a fix quickly for this, too... 😉 Still some hops on this side.

@tebanep
Copy link
Copy Markdown
Contributor

tebanep commented Dec 14, 2018

@blaggacao Should I merge this already?

@blaggacao
Copy link
Copy Markdown
Contributor Author

blaggacao commented Dec 14, 2018

I guess you can merge it, yes. Found something, not yet...

@blaggacao
Copy link
Copy Markdown
Contributor Author

@tebanep That one seems good now.
Hey nice! I guess, it's deploy-able after this... :) At least with:
pip install git+https://github.com/nubark/facturark.git@master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants