Closed
Conversation
ec73fb7 to
28a6f82
Compare
# Conflicts: # facturark/api.py # facturark/composers/amount_composer.py # facturark/composers/party_composer.py # facturark/resolver.py
28a6f82 to
7b3f358
Compare
Contributor
Author
|
I see there is still more to it. Basically, the problem here consists in simplifying the XML API and break it down to sensible defaults. Maybe, after finishing to build the minimal low level API, the original pre flight idea is a better way to achieve consistency and a simplified API. I guess really we need a simplifying layer. @tebanep Am I right assuming that you are trying to solve the problem of this first component anyway? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Something around those lines to tackle: #13
This is a WIP, please let me know if this takes a direction that would be worth discussing... 😉