Skip to content

fix(KNO-12548): Update link styling in Table cells#1386

Open
rachael-t wants to merge 1 commit intomainfrom
rt-kno-12548-update-table-links
Open

fix(KNO-12548): Update link styling in Table cells#1386
rachael-t wants to merge 1 commit intomainfrom
rt-kno-12548-update-table-links

Conversation

@rachael-t
Copy link
Copy Markdown
Contributor

@rachael-t rachael-t commented Apr 9, 2026

Description

This updates links in Table cells so that styling is applied to make it clear to users that they are links. In my review, it looks like we just needed to update content/integrations/extensions/data-sync.mdx (both messages and recipient changes tables) and content/template-editor/reference-liquid-helpers.mdx (link)

Tasks

KNO-12548

Screenshots

Before:
Screenshot 2026-04-09 at 12 41 35 PM

After:
Screenshot 2026-04-09 at 12 41 17 PM

@linear
Copy link
Copy Markdown

linear bot commented Apr 9, 2026

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 9, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview, Comment Apr 9, 2026 6:40pm

Request Review

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Risk MEDIUM: Adds inline link styling (color and textDecoration) to <a> tags within Table cells across two MDX content files.

Reasons

  • Only .mdx content files are modified (no component, layout, or config changes), which avoids HIGH risk triggers.
  • Changes span two different documentation sections (content/integrations/ and content/template-editor/), which triggers a MEDIUM classification.
  • The diff is 88 additions / 14 deletions across 2 files — moderately sized but mostly whitespace reformatting from expanding inline JSX into multi-line blocks.
  • No new pages, sidebar changes, or dependency updates are involved.
  • The styling approach uses inline style attributes with CSS variables rather than modifying shared components or stylesheets.

Notes

  • Verify that var(--tgph-accent-11) renders correctly in all themes/contexts where these Table cells appear.
  • Consider whether a shared CSS class or component-level style for table links would be more maintainable than repeating inline styles on each <a> tag (the same style object is applied ~8 times).
  • Confirm that target="_blank" and rel="noreferrer" are intentionally added to internal doc links (e.g., #date-format-options anchor links) — same-page anchors typically don't need to open in new tabs.
Open in Web View Automation 

Sent by Cursor Automation: Docs PR classifier

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 6bec450. Configure here.

delivery status of a message
</a>.
</a>
.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unwanted space before period after link text

Low Severity

Splitting the </a> tag and the period onto separate lines in JSX causes an extra space to appear before the period due to whitespace normalization, rendering "delivery status of a message ." instead of "delivery status of a message."

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 6bec450. Configure here.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that Prettier is enforcing this and doesn't actually end up impacting how it renders:

Screenshot 2026-04-09 at 12 47 06 PM

@rachael-t rachael-t requested a review from a team April 9, 2026 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant