fix(KNO-12271): Add target="_blank" to external links in docs#1381
fix(KNO-12271): Add target="_blank" to external links in docs#1381
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| When specifying a dynamic window you must provide one of the following: | ||
|
|
||
| - An **[ISO-8601 timestamp](https://en.wikipedia.org/wiki/ISO_8601)** (e.g. `2022-05-04T20:34:07Z`) which must be a datetime in the future | ||
| - An <a href="https://en.wikipedia.org/wiki/ISO_8601" target="_blank" rel="noopener noreferrer">ISO-8601 timestamp</a> (e.g. `2022-05-04T20:34:07Z`) which must be a datetime in the future |
There was a problem hiding this comment.
I removed the bold styling to keep it consistent with the batch and delay pages.
There was a problem hiding this comment.
Risk MEDIUM: Adds target="_blank" to external links across 70 MDX content files by converting markdown links to HTML <a> tags with rel="noopener" (or rel="noopener noreferrer" for informational reference sites).
Reasons
- All 70 changed files are
.mdxcontent files — no components, layouts, config, or dependency changes (avoids HIGH triggers) - Changes span many documentation sections (
concepts/,integrations/,developer-tools/,in-app-ui/,getting-started/, and more), triggering the multi-section MEDIUM rule - Total diff is 329 lines (189+/140-) across 70 files, which exceeds the LOW risk threshold of 50 total lines
- The conversion from markdown link syntax to raw HTML
<a>tags is mechanical but changes how MDX renders these elements, which could surface subtle rendering differences - No new pages, sidebar changes, or structural changes — the content meaning is preserved
Notes
- Verify that converted
<a>tags render identically to the original markdown links in the deployed preview (font, color, underline, hover state) - Spot-check that
rel="noopener noreferrer"vsrel="noopener"was applied consistently per the stated policy (informational reference sites vs. Knock-owned/partner sites) - The PR description notes that links inside markdown lists and JSX component prop strings were intentionally skipped — confirm these remaining links still behave as expected
- Watch for any accidental content changes beyond the link conversion (e.g., whitespace or text changes)
Sent by Cursor Automation: Docs PR classifier
cellomatt
left a comment
There was a problem hiding this comment.
Thanks for these updates! I think it's worth looking into the formatting stuff flagged by bugbot to see if you can update it and still have it look correct/pass prettier formatting, but other than that lgtm 👍
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 3 total unresolved issues (including 2 from previous reviews).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 67602c3. Configure here.



Description
Audits all external links in the docs to ensure they open in a new tab, preventing users from being navigated away from the docs site.
Note that this PR only updates external links that appear in prose and callouts. External links inside markdown lists (
- [text](url)) and inside JSX component prop strings were intentionally left unchanged. This is because I was running into some rendering issues that require further investigation (see KNO-12286 and KNO-12420 for details). This PR at least updates most external links.In this PR, I made the following changes:
[text](url)in paragraphs and callouts were converted to<a href="url" target="_blank" rel="noopener">text</a>.rel="noopener noreferrer"added to purely informational reference sites. Links to Wikipedia, MDN, json-schema.org, Shopify Liquid docs, react.dev, nextjs.org, and brew.sh were givennoreferrerin addition tonoopener.noopenerapplied.Tasks
KNO-12271