Increase http clients' max_clients to 100#133
Open
j3k0 wants to merge 1 commit intoklen:pyup-initial-updatefrom
Open
Increase http clients' max_clients to 100#133j3k0 wants to merge 1 commit intoklen:pyup-initial-updatefrom
j3k0 wants to merge 1 commit intoklen:pyup-initial-updatefrom
Conversation
When some HTTP requests take too long, the queue of request gets filled up and other requests fail with timeouts / too lon to process errors. This is a simple (naive?) attempt to fix those errors, by increasing the max number of concurrent requests being processed.
Collaborator
|
Thanks for contributing, @j3k0! Would you mind making this a configuration option and only explicitly setting the max number of connections if it is set? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When some HTTP requests take too long, the queue of requests gets filled up and other requests, that shouldn't fail, fail too with timeouts / too long to process errors.
Logs showed errors like this:
[simple_httpclient:137:fetch_impl] max_clients limit reachedSo it seems I fell into this case: http://stackoverflow.com/questions/33411493/max-clients-limit-reached-request-queued-tornado
This is a simple (naive?) attempt to fix those errors (based on the stackoverflow answer). Increasing the max number of concurrent requests being processed by tornado seems to fix my problems, on my setup.